Skip to content

First post-processing functions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

TatjanaWeiler
Copy link
Contributor

Some functions to post-process LaMEM models. Plotting functions are in progress.

Some functions to post-process LaMEM models. Plotting functions are in progress.
TatjanaWeiler and others added 12 commits May 7, 2025 17:36
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
@boriskaus
Copy link
Member

boriskaus commented May 8, 2025

thanks a lot for your PR, this seems very helpful.
The only thing I wondering is whether this is not something that should rather be part of the LaMEM.jl package as it is quite specific to that code. I realise that we do have a few additional LaMEM-specific routines in here, but perhaps we should move them over as well at some stage.

If the future plotting routines you want to add will be specific to LaMEM they should go there; if they will be more general and can deal with any CartData structure, they can be added here (note that GLMakie is already an optiona; dependency of GMG).

@albert-de-montserrat
Copy link
Member

thanks a lot for your PR, this seems very helpful. The only thing I wondering is whether this is not something that should rather be part of the LaMEM.jl package as it is quite specific to that code. I realise that we do have a few additional LaMEM-specific routines in here, but perhaps we should move them over as well at some stage.

Or alternatively, there could be a LaMEM extension in GMG, and move there also the other LaMEM-specific functions.

@mthielma
Copy link
Contributor

I agree that it would be good to put all the LaMEM related functions in an LaMEM extension as Albert suggested. This way we could potentially have different extensions for different geodynamic (or other) codes. If we do this, we should however first have a plan on how the extension should look like. From summer/autumn on, I should hopefully also have hired someone who could work on this.

@boriskaus
Copy link
Member

I'm not sure how this will work, as GMG is a fixed dependency of LaMEM.jl so I guess we would run into a circular dependency here, not?

@TatjanaWeiler
Copy link
Contributor Author

Most of the plotting functions will work for general CartData structures.

@boriskaus
Copy link
Member

ok, in that case let's leave the routines here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants