-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: auto trigger binary release #4587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto trigger binary release #4587
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR adds an auto-trigger mechanism for binary releases but introduces critical issues. The changes include commenting out all Docker build steps in existing jobs and adding a new trigger-binary-release
job that creates tags in the infisical-omnibus
repository. However, the implementation has several problems that prevent it from working correctly.
Major issues found:
- Hardcoded tag version instead of using dynamic
${{ github.ref_name }}
- Missing required
GITHUB_TOKEN
environment variable for GitHub API calls - Job dependencies pointing to jobs that no longer perform actual work
- Development branch trigger that should be removed before merging
- Syntax issues with commented-out code mixed with active code
The workflow will fail in its current state due to missing authentication and incorrect tag reference.
Confidence Score: 1/5
- This PR has critical issues that prevent it from working and should not be merged in its current state
- Score reflects multiple critical logical errors including missing authentication, hardcoded values, broken job dependencies, and syntax issues that will cause workflow failures
- The workflow file requires significant fixes before it can function properly - particularly the authentication, tag reference, and job dependency issues
Important Files Changed
File Analysis
Filename | Score | Overview |
---|---|---|
.github/workflows/release-standalone-docker-img-postgres-offical.yml | 1/5 | Added auto trigger binary release job with multiple critical issues: hardcoded tag version, missing GITHUB_TOKEN, dependency on empty jobs, commented out all Docker build steps |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Actions
participant Tests as infisical-tests
participant Standalone as infisical-standalone
participant FIPS as infisical-fips-standalone
participant Trigger as trigger-binary-release
participant OmnibusRepo as infisical-omnibus
Note over GHA: Triggered by tag push or branch push
GHA->>Tests: Start backend tests
Tests-->>GHA: ✓ Tests complete
par Parallel Docker Jobs
GHA->>Standalone: Start standalone job
Note over Standalone: ⚠️ Only extracts version (Docker build commented out)
Standalone-->>GHA: ✓ Version extracted only
and
GHA->>FIPS: Start FIPS standalone job
Note over FIPS: ⚠️ Only extracts version (Docker build commented out)
FIPS-->>GHA: ✓ Version extracted only
end
Note over Trigger: Depends on both Docker jobs
GHA->>Trigger: Start trigger job
Note over Trigger: ❌ Missing GITHUB_TOKEN
Trigger->>OmnibusRepo: Check if tag exists (fails without auth)
Trigger->>OmnibusRepo: Get latest main SHA (fails without auth)
Note over Trigger: ❌ Uses hardcoded tag instead of github.ref_name
Trigger->>OmnibusRepo: Create tag with wrong version (fails)
Trigger-->>GHA: ❌ Job fails
1 file reviewed, 5 comments
Description 📣
Automatically trigger Infisical Binary releases when a new standalone docker image is released. This works for both nighly and stable.
Type ✨