Skip to content

Added support of empty strings #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support of empty strings #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private function getEnvValues(array $envMap)
$params = array();
foreach ($envMap as $param => $env) {
$value = getenv($env);
if ($value) {
if ($value !== false) {
$params[$param] = Inline::parse($value);
}
}
Expand Down
1 change: 1 addition & 0 deletions Tests/fixtures/testcases/non_existent_with_environment/dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ parameters:
foo: bar
boolean: false
another: ~
empty: nonempty
nested:
foo: bar
bar: baz
1 change: 1 addition & 0 deletions Tests/fixtures/testcases/non_existent_with_environment/expected.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ parameters:
foo: foobar
boolean: true
another: null
empty: ''
nested:
foo: env_foo
bar:
Expand Down
2 changes: 2 additions & 0 deletions Tests/fixtures/testcases/non_existent_with_environment/setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ config:
foo: IC_TEST_FOO
nested: IC_TEST_NESTED
another: IC_TEST_NOT_SET
empty: IC_TEST_EMPTY

environment:
IC_TEST_BOOL: 'true'
IC_TEST_FOO: 'foobar'
IC_TEST_NESTED: '{foo: env_foo, bar: [env, test, null]}'
IC_TEST_EMPTY: ''