Combo/SimpleCombo/DatePicker aria-required properties addition - 20.0.x #16047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/IgniteUI/igniteui-angular into sstoychev/bypassing-input-required-logic-20
ChronosSF
added
♿ a11y
ChronosSF
changed the title
rkaraivanov
reviewed
Jul 29, 2025
| @@ -9,6 +9,8 @@ | |||
| <ng-content select="igx-hint, [igxHint]"></ng-content> | |||
| </ng-container> | |||
| <input igxInput #comboInput name="comboInput" type="text" [value]="displayValue" readonly | |||
| [required]="required" [attr.aria-required]="required" | |||
There was a problem hiding this comment.
Suggested change
| [required]="required" [attr.aria-required]="required" | |
| [required]="required" |
IMO this is clutter, since the required attribute on a native input element semantically does the same thing.
| @@ -13,6 +13,7 @@ | |||
| </ng-container> | |||
|
|
|||
| <input #comboInput igxInput [value]="displayValue" role="combobox" | |||
| [required]="required" [attr.aria-required]="required" [externalValidate]="externalValidate" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16000
Closes #15837
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)