Support Django 5.2.1 and elasticsearch-dsl 7.x #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddusim
commented
Jul 21, 2025
ddusim
commented
- Update setup.py dependencies to elasticsearch-dsl>=7.0.0,<8.0.0
- Add Django 5.x classifiers and Python 3.12 support
- Fix DocType import (replaced with Document for elasticsearch-dsl 7.x)
- Bump version to 7.0.0a1
- Update setup.py dependencies to elasticsearch-dsl>=7.0.0,<8.0.0 - Add Django 5.x classifiers and Python 3.12 support - Fix DocType import (replaced with Document for elasticsearch-dsl 7.x) - Bump version to 7.0.0a1
|
@ddusim I don't think we should merge to master? Can we tag this branch and have CP requirements install that tag? I believe that's what the previousl upgrades did - I don't believe they were merged to master |
…pe() calls - Replace super().doc_type() calls with direct doc_type handling - Fixes AttributeError: 'super' object has no attribute 'doc_type' - Compatible with newer elasticsearch-dsl versions that removed doc_type method - Maintains backward compatibility by using stored __doc_type attribute
|
@kofic I am using this in requirements.in git+https://github.com/HBS-HBX/django-elastic-migrations.git@django-5.2.1-elasticsearch-7-clean and I don't think we need to merge this branch |
|
@ddusim nice looks great 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.