Clean up code by using Iterator::collect() when constructing instance tables #2918
+980
−1,001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few nodes editing InstanceTables have this sort of code:
Now you can write them like this:
Steams also have the advantage that in simple cases like these, the resulting vec can use
Iterator:size_hint()
to allocate the exact amount of entries it needs, whereas the for loop variant it may go through multiple resizes and overallocate memory.