Skip to content

Point sliding on G G #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Point sliding on G G #2913

wants to merge 5 commits into from

Conversation

4adex
Copy link
Collaborator

@4adex 4adex commented Jul 20, 2025

Closes #2715

@Keavon
Copy link
Member

Keavon commented Jul 25, 2025

This doesn't appear to do anything, from what I can tell. Did you test it? Or misunderstand what is desired?

@4adex
Copy link
Collaborator Author

4adex commented Jul 25, 2025

https://4778b953.graphite.pages.dev/
It is working in the deployement, before your code review commit @Keavon
Screencast from 25-07-25 09:49:36 AM IST.webm
I will fix it

@Keavon
Copy link
Member

Keavon commented Jul 25, 2025

Oh, it doesn't work on ellipses. I tested your commit before doing my code review. (It sounds like I also broke something in my code review/)

@Keavon
Copy link
Member

Keavon commented Jul 25, 2025

We also need hints during G/R/S, including (when available) the subsequent G to slide. I seem to recall we already had working G/R/S hints but we don't seem to currently in the Path tool. Maybe I was just remembering the Select tool's ones.

@4adex 4adex marked this pull request as ready for review July 27, 2025 07:26
@4adex 4adex marked this pull request as draft July 27, 2025 07:26
@Keavon
Copy link
Member

Keavon commented Jul 28, 2025

Still supposed to be a draft?

@4adex
Copy link
Collaborator Author

4adex commented Jul 28, 2025

The hints are not updated yet, but hints have been changed to dynamic ones in #2860 so was waiting for merger of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point sliding with G G
2 participants