Skip to content

chore: typescript api #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 28, 2025
Merged

chore: typescript api #5807

merged 12 commits into from
Jul 28, 2025

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 22, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Requires #5802 to be merged first

Changes

Converts api.js to TypeScript

How did you test this code?

  • E2E
  • Manual demo regression test against production

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 22, 2025 15:38
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team July 22, 2025 15:38
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 4:20pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 4:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2025 4:20pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jul 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5807 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5807 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5807 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5807 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5807 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5807 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title Chore/typescript api chore: typescript api Jul 22, 2025
Base automatically changed from chore/remove-heap-mixpanel to main July 22, 2025 16:11
@kyle-ssg kyle-ssg requested review from a team as code owners July 22, 2025 16:11
@kyle-ssg kyle-ssg requested review from emyller and removed request for a team July 22, 2025 16:11
@kyle-ssg
Merge branch 'main' into chore/typescript-api
13ab248 
# Conflicts:
#	frontend/web/project/api.js
@github-actions github-actions bot added the chore label Jul 22, 2025
Zaimwa9
Zaimwa9 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a foundation to improve gradually

@kyle-ssg kyle-ssg merged commit 6b0a985 into main Jul 28, 2025
25 checks passed
@kyle-ssg kyle-ssg deleted the chore/typescript-api branch July 28, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo tiagoapolo is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@emyller emyller Awaiting requested review from emyller emyller was automatically assigned from Flagsmith/flagsmith-docs

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @Zaimwa9