-
Notifications
You must be signed in to change notification settings - Fork 450
fix: allow access to dashboard for FoF when sdk init error 🔴 blocked by SDK #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
<> | ||
{' '} | ||
Check{' '} | ||
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not fundamental part of this PR but we should consider replacing this with https://status.flagsmith.com/ because we're not posting status updates on twitter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agree with this, but let's include this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Only one minor optional change
<> | ||
{' '} | ||
Check{' '} | ||
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'> | |
<a target='_blank' href='https://status.flagsmith.com/' rel='noreferrer'> |
{' '} | ||
Check{' '} | ||
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'> | ||
@getflagsmith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getflagsmith | |
Flagsmith status |
</Row> | ||
<p className='mb-1'>The error was: "{fofError}"</p> | ||
<p className='mb-1'> | ||
Flag evaluation for is not affected, but some dashboard features might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, looks like there's a typo:
Flag evaluation for is not affected, but some dashboard features might | |
Flag evaluation is not affected, but some dashboard features might |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Instead of Maintenance screen or infinite loading, FoF users have access to the platform
isFlagsmithOnFlagsmith
computed envHow did you test this code?