Skip to content

fix: allow access to dashboard for FoF when sdk init error 🔴 blocked by SDK #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jun 26, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

⚠️ Behavior changed only for FoF

Instead of Maintenance screen or infinite loading, FoF users have access to the platform

  • Added isFlagsmithOnFlagsmith computed env
  • Changed initialization error from boolean to literals
  • Allow dashboard access with default flags in case of initialization error (Specifically empty API and ENV_ID for now)
  • Sticky error message

How did you test this code?

image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 26, 2025 14:48
@Zaimwa9 Zaimwa9 requested review from tiagoapolo and removed request for a team June 26, 2025 14:48
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 3:21pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 3:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 3:21pm

Copy link
Contributor

github-actions bot commented Jun 26, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5658 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5658 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-5658 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-5658 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5658 Finished ✅ Results

<>
{' '}
Check{' '}
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fundamental part of this PR but we should consider replacing this with https://status.flagsmith.com/ because we're not posting status updates on twitter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely agree with this, but let's include this in a separate PR.

@Zaimwa9 Zaimwa9 requested review from tiagoapolo and khvn26 June 30, 2025 08:03
Copy link
Contributor

@tiagoapolo tiagoapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Only one minor optional change

<>
{' '}
Check{' '}
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'>
<a target='_blank' href='https://status.flagsmith.com/' rel='noreferrer'>

{' '}
Check{' '}
<a target='_blank' href='https://x.com/getflagsmith' rel='noreferrer'>
@getflagsmith
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@getflagsmith
Flagsmith status

</Row>
<p className='mb-1'>The error was: "{fofError}"</p>
<p className='mb-1'>
Flag evaluation for is not affected, but some dashboard features might
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like there's a typo:

Suggested change
Flag evaluation for is not affected, but some dashboard features might
Flag evaluation is not affected, but some dashboard features might

@Zaimwa9 Zaimwa9 changed the title fix: allow access to dashboard for FoF when sdk init error fix: allow access to dashboard for FoF when sdk init error 🔴 blocked by SDK Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants