Skip to content

feat: send flagsmith sdk user agent #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: send flagsmith sdk user agent #332

wants to merge 6 commits into from
+25 −3

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jul 28, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Closes #326

Changes

  • Write version at build-time
  • Re-uses SDK version to pass in the header Flagsmith-sdk-user-agent as flagsmith-js-sdk/{version}
  • Removed evaluation-context type generation based on flagsmith repo

How did you test this code?

image

kyle-ssg
kyle-ssg reviewed Jul 29, 2025
View reviewed changes
@Zaimwa9 Zaimwa9 requested a review from kyle-ssg July 30, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send Flagsmith-SDK-User-Agent
2 participants
@Zaimwa9 @kyle-ssg