Terrain Drag Marking Update #1668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
requested changes
Jul 3, 2025
| @@ -8,7 +8,8 @@ | |||
| #include "amr-wind/utilities/IOManager.H" | |||
| #include "amr-wind/utilities/io_utils.H" | |||
| #include "amr-wind/utilities/linear_interpolation.H" | |||
|
|
|||
| #include "amr-wind/fvm/gradient.H" | |||
| #include "amr-wind/utilities/constants.H" | |||
There was a problem hiding this comment.
I don't think these includes are necessary?
| @@ -183,6 +199,36 @@ void KransAxell::operator()( | |||
| terrainforcing = | |||
| (ustar * ustar / (Cmu * Cmu) + rans_b - tke_arr(i, j, k)) / | |||
| dt; | |||
| if (drag_arr(i, j, k) > 1) { | |||
| //! West | |||
| ustar = compute_target_ustar( | |||
There was a problem hiding this comment.
can we do a for loop? if you cast as iv and then loop on dir and to iv +/- thedimensionvector(dir) it should do this automatically.
| } else { | ||
| levelDrag[nbx](i, j, k, 0) = 0; | ||
| } | ||
| const int blankxp = std::abs( |
There was a problem hiding this comment.
can we do a for loop? see comment above
| amrex::Real bc_forcing_t = -(tTarget - theta) / dt; | ||
| //! West | ||
| if (drag(i, j, k) > 1) { | ||
| amrex::Real tmp_temp_target = compute_target_theta( |
There was a problem hiding this comment.
Another for loop opportunity
| compute_target_wind( | ||
| vel(i - 1, j, k, 2), vel(i - 1, j, k, 1), dx[0], z0, | ||
| kappa); | ||
| bc_forcing_z += |
There was a problem hiding this comment.
for loop opportunity (see comments below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing approach for marking terrain is rudimentary. We only check the terrain height. This works well for neutral boundary layer as the terrain is forced to zero wind speed. However, for non-neutral condition at very stable or unstable states, soil temperature leaks into the domain providing a unrealistic stratification effect. This PR updates the terrain marking algorithm to account for the terrain effects in the horizontal direction. The horizontal wall function is computed using MOST.
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Before
After