-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[WIP] add fees breakdown for aave, euler, morpho #3730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
|
||
export interface AaveLendingPoolConfig { | ||
version: 1 | 2 | 3; | ||
lendingPoolProxy: string; | ||
dataProvider: string; | ||
|
||
// GHO on aave | ||
seflLoanAssets?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to keep it as an array? what if there are more than one?
helpers/metrics.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link each enum item to short label and description?
And maybe let users add their own in their adapter if it is applicable to only their protocol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to move methodology outside the chain and move it to the top level, it is going to be a pain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*at some point in the near future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link each enum item to short label and description?
And maybe let users add their own in their adapter if it is applicable to only their protocol?
hmm, how about we add a field of breakdownMethodology
in meta
, and use it in the same way of methodology
to explain breakdown fields?
yes, we allow users to add their own in their adapter, like I did with GHO stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
The aave adapter exports:
|
The euler adapter exports:
|
The hypurrfi adapter exports:
|
The morpho adapter exports:
|
No description provided.