-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Gauntlet Aera v2 - add Morpho borrow positions #15551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
geoffgxyz
wants to merge
8
commits into
DefiLlama:main
Choose a base branch
from
geoffgxyz:gauntlet_aera_v2_morpho_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f77ef55
simplify to using primary vault total supply for tvl
geoffgxyz 3a7fd14
add comment about single-depositor vaults
geoffgxyz fb6da5d
use vault decimals instead of hard-coding
geoffgxyz d4abeff
add morpho tvl computation to aera v2
geoffgxyz 39e921d
cleanup
geoffgxyz a241b3e
handle ERC4626 morpho collateral tokens
geoffgxyz 87bef09
Merge branch 'main' into gauntlet_aera_v2_morpho_fixes
geoffgxyz c0353f1
parallelize a couple of calls
geoffgxyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove any try/catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you propose an alternative? Some Morpho positions use collateral in ERC4626 contracts. In order to account for the collateral for these positions we need to get the underlying asset and convert shares to assets. But invoking ERC4626 functions on contracts that do not support these methods will revert. Without this logic we account for the borrowed asset but not the collateral, which results in a large negative position.