Skip to content

Release: Merge back 2.48.4 into dev from: master-into-dev/2.48.4-2.49.0-dev #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Release triggered by Maffooch

DefectDojo release bot and others added 6 commits July 21, 2025 21:49
….49.0-dev

Release: Merge back 2.48.3 into bugfix from: master-into-bugfix/2.48.3-2.49.0-dev
As part of #12782 the default value for `close_old_findings` was swapped from `True` to `False`. This PR restores that functionality
* Update versions in application files

* Reimport: Restore default for `close_old_findings` to `True` (#12837)

As part of #12782 the default value for `close_old_findings` was swapped from `True` to `False`. This PR restores that functionality

* Update versions in application files

---------

Co-authored-by: DefectDojo release bot <dojo-release-bot@users.noreply.github.com>
Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com>
Copy link

dryrunsecurity bot commented Jul 22, 2025

DryRun Security

This pull request identifies a potential security risk in the API serializer where changing the default value for 'close_old_findings' could lead to unintentional closure of valid security findings, potentially creating a false sense of security.

Unintended Closure of Findings via API Default Change in dojo/api_v2/serializers.py
Vulnerability Unintended Closure of Findings via API Default Change
Description The default value for 'close_old_findings' in the ReImportScanSerializer has been changed from False to True. This means that when a user re-imports a scan via the API without explicitly setting the close_old_findings parameter, any findings from the previous scan that are not present in the new report will be automatically closed as mitigated. This behavior differs from the standard ImportScanSerializer, which defaults to False, and could lead to the unintentional closure of valid security findings, creating a false sense of security and potentially masking real vulnerabilities.

# also for ReImport.
close_old_findings = serializers.BooleanField(
required=False,
default=True,
help_text="Old findings no longer present in the new report get closed as mitigated when importing. "
"If service has been set, only the findings for this service will be closed. "
"This only affects findings within the same test.",


All finding details can be found in the DryRun Security Dashboard.

Copy link
Contributor Author

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor Author

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch Maffooch merged commit 5eff6e4 into dev Jul 22, 2025
156 of 157 checks passed
@Maffooch Maffooch deleted the master-into-dev/2.48.4-2.49.0-dev branch July 22, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant