importers: clean tags before saving #12811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
New Migration
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
github-actions
bot
removed
settings_changes
valentijnscholten
force-pushed
the
sysdig-tags-fix
branch
from
0da2d5b to
836c538
Compare
Maffooch
approved these changes
Jul 21, 2025
rossops
approved these changes
Jul 21, 2025
Jino-T
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parsers such as the
sysdigparsers were inserting spaces intotags. This violates the validation rules introduced recently.This PR:
importandreimportto replace invalid characters in tags with '_' using a newclean_tagsfunctionclean_tagsfunction (as an example)In general we want to improve data validation for import/reimport which we'll be looking at next. For now we wanted to do a specific fix for the sysdig parsers and general tags usage. But we didn't want to completely block on any invalid characters in tags as they might appear in place where the user has little or no control.
For other fields there is the same risk. So validating all fields and raising errors or skipping invalid findings is for a next PR in a monthly release where we can test various cases and provide informtion in the release notes/upgrade notes.