Skip to content

Sysdig parser: Add new CSV and JSON formats #12022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 3, 2025

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Mar 15, 2025

Description
Add support for reports created by the Sysdig CLI Scanner.
Fixes #11843

Test results
Added unit tests.

Documentation
Added docs page.

@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR integration_tests ui conflicts-detected helm lint labels Mar 29, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@valentijnscholten valentijnscholten changed the base branch from dev to bugfix March 29, 2025 09:05
@valentijnscholten valentijnscholten marked this pull request as ready for review March 29, 2025 09:07
Copy link

dryrunsecurity bot commented Mar 29, 2025

DryRun Security Summary

A review of Sysdig vulnerability parser patches revealed potential security concerns including input validation issues, information exposure risks, and error handling vulnerabilities across multiple files.

Expand for full summary

Summary: Multiple patches related to Sysdig vulnerability parsers and documentation were reviewed, introducing new parsing capabilities for Sysdig CLI and Reports vulnerability scanners across various files.

Security Findings:

  1. Input Validation Concerns in dojo/tools/sysdig_cli/parser.py:

    • No explicit sanitization of input data before processing
    • Potential information exposure through detailed vulnerability logging
    • Broad exception handling in JSON parsing could mask security issues
  2. Potential Information Exposure:

    • Commented-out fields might contain sensitive information like k8s cluster names or cloud provider account IDs
    • Detailed logging of vulnerability information could reveal system details
  3. Decoding Considerations:

    • Use of .decode("utf-8") for byte content could be a potential vector for encoding-based attacks if not carefully implemented
  4. File Type and Input Handling:

    • Restricts file processing to .csv and .json extensions
    • Validates CSV headers and column structures
    • Checks CVSS version and score processing
  5. Error Handling Risks:

    • Broad exception handling in JSON parsing
    • Raises ValueError for unexpected file formats
    • Potential for masking underlying security issues

No hardcoded credentials or tokens were detected across the reviewed patches.

View PR in the DryRun Dashboard.

@github-actions github-actions bot removed New Migration Adding a new migration file. Take care when merging. settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR integration_tests ui helm labels Mar 29, 2025
@github-actions github-actions bot removed the lint label Mar 29, 2025
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit b5eeb7f into DefectDojo:bugfix Apr 3, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants