RefreshStoredProcedureParameters if database side change StoredProcedure interface (parameter declarations)

Author: AbelCheng

.nuget/NuGet.exe

@@ -31,7 +31,7 @@ public static TimeSpan ExpireInterval
 		static DerivedParametersCache()
 		{
 			_CacheRoot = new ConcurrentDictionary<string, StoredProcedureDictionary>(StringComparer.OrdinalIgnoreCase);
-			ExpireInterval = TimeSpan.FromHours(1);	// Default 1 hour
+			ExpireInterval = TimeSpan.FromHours(2);	// Defaults to 2 hour
 		}
 
 		#region Private Basic Operations

DataAccess/Cache/DerivedParametersCache.cs

@@ -95,32 +95,32 @@ private DbCommand CreateCommand(string commandText, int commandTimeout, CommandT
 		private DbDataReader CreateReader(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder, int resultSetCnt = 1)
 		{
 			int recordsAffected;
-			return InternalExecute(commandText, commandTimeout, commandType, parametersBuilder, resultSetCnt, out recordsAffected);
+			return ExecuteCommandInternal(commandText, commandTimeout, commandType, parametersBuilder, resultSetCnt, out recordsAffected);
 		}
 
-		private DbDataReader InternalExecute(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder, int resultSetCnt, out int recordsAffected)
+		private DbDataReader ExecuteCommandInternal(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder, int resultSetCnt, out int recordsAffected)
 		{
-			for (int retry = 2; ; retry--)
+			for (int retry = 0; ; retry++)
 			{
 				try
 				{
 					DbCommand dbCmd = CreateCommand(commandText, commandTimeout, commandType, parametersBuilder);
 
-					if (resultSetCnt > 0)
+					if (resultSetCnt < 0)
 					{
-						OnReaderExecuting(dbCmd, resultSetCnt);
-						recordsAffected = -1;
-						return dbCmd.ExecuteReader();
+						recordsAffected = dbCmd.ExecuteNonQuery();
+						return null;
 					}
 					else
 					{
-						recordsAffected = dbCmd.ExecuteNonQuery();
-						return null;
+						OnReaderExecuting(dbCmd, resultSetCnt);
+						recordsAffected = -1;
+						return dbCmd.ExecuteReader();
 					}
 				}
 				catch (Exception e)
 				{
-					if (retry <= 0)
+					if (retry > 0)
 						throw;
 
 					switch (OnContextLost(e))
@@ -268,7 +268,7 @@ public int ExecuteNonQuery(string commandText, int commandTimeout, CommandType c
 		{
 			int recordsAffected;
 
-			InternalExecute(commandText, commandTimeout, commandType, parametersBuilder, 0, out recordsAffected);
+			ExecuteCommandInternal(commandText, commandTimeout, commandType, parametersBuilder, -1, out recordsAffected);
 
 			return recordsAffected;
 		}

DataAccess/DbAccess.cs

@@ -35,10 +35,7 @@ partial void OnOracleContextLost(Exception dbException, ref RetryAction retryAct
 							retryAction = RetryAction.Reconnect;
 							break;
 						case 6550:
-							if (e.Errors.Count == 1 && e.Message.Contains("PLS-00306: "))
-								retryAction = RetryAction.RefreshParameters;
-							else
-								retryAction = RetryAction.None;
+							retryAction = (e.Errors.Count == 1 && e.Message.Contains("PLS-00306: ")) ? RetryAction.RefreshParameters : RetryAction.None;
 							break;
 						// To add other cases
 						default:

DataAccess/Oracle/DbAccess.partial.cs

@@ -17,18 +17,22 @@ partial void OnSqlContextLost(Exception dbException, ref RetryAction retryAction
 				if (e == null)
 					retryAction = RetryAction.None;
 				else
-					switch (e.Number)
+					switch (e.Number)	// sys.messages
 					{
 						case 233:
 						case -2:
+						case 10054:
 							retryAction = RetryAction.Reconnect;
 							break;
-						case 201:
-						case 8144:
+						case 201:		// Procedure or function '%.*ls' expects parameter '%.*ls', which was not supplied.
+						case 206:		// Operand type clash: %ls is incompatible with %ls.
+						case 257:		// Implicit conversion from data type %ls to %ls is not allowed. Use the CONVERT function to run this query.
+						case 8144:		// Procedure or function %.*ls has too many arguments specified.
 							retryAction = RetryAction.RefreshParameters;
 							break;
 						// To add other cases
-						default: retryAction = RetryAction.None;
+						default:
+							retryAction = RetryAction.None;
 							break;
 					}