Preparing RetryAction.RefreshParameters

Author: AbelCheng

DataAccess/DbAccess.cs

@@ -23,9 +23,6 @@ public static bool AutoDeriveRefCursorParameters
 			set { AutoDeriveRefCursorParameters = value; }
 		}
 
-		private const int _MaxRetryCount = 2;
-		private const int _IncreasingDelayRetry = 500;		// Increases 500 milliseconds delay time for every retry.
-
 		private DbProviderFactory _ProviderFactory;
 		private DbConnection _Connection;
 		public DbConnection Connection
@@ -39,6 +36,13 @@ public DbConnection Connection
 			}
 		}
 
+		private enum RetryAction
+		{
+			None = 0,
+			Reconnect = 1,
+			RefreshParameters = 2
+		}
+
 		#region Constructors
 
 		public DbAccess(DbProviderFactory dbProviderFactory, string connectionString)
@@ -90,22 +94,49 @@ private DbCommand CreateCommand(string commandText, int commandTimeout, CommandT
 
 		private DbDataReader CreateReader(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder, int resultSetCnt = 1)
 		{
-			for (int retry = 0; ; retry++)
+			int recordsAffected;
+			return InternalExecute(commandText, commandTimeout, commandType, parametersBuilder, resultSetCnt, out recordsAffected);
+		}
+
+		private DbDataReader InternalExecute(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder, int resultSetCnt, out int recordsAffected)
+		{
+			for (int retry = 2; ; retry--)
 			{
 				try
 				{
 					DbCommand dbCmd = CreateCommand(commandText, commandTimeout, commandType, parametersBuilder);
 
-					OnReaderExecuting(dbCmd, resultSetCnt);
-
-					return dbCmd.ExecuteReader();
+					if (resultSetCnt > 0)
+					{
+						OnReaderExecuting(dbCmd, resultSetCnt);
+						recordsAffected = -1;
+						return dbCmd.ExecuteReader();
+					}
+					else
+					{
+						recordsAffected = dbCmd.ExecuteNonQuery();
+						return null;
+					}
 				}
 				catch (Exception e)
 				{
-					if (retry < _MaxRetryCount && OnConnectionLost(e))
-						ReConnect(retry);
-					else
+					if (retry <= 0)
 						throw;
+
+					switch (OnContextLost(e))
+					{
+						case RetryAction.Reconnect:
+							ReConnect();
+							break;
+						case RetryAction.RefreshParameters:
+							if (commandType == CommandType.StoredProcedure)
+								RefreshStoredProcedureParameters(commandText);
+							else
+								throw;
+							break;
+						default:
+							throw;
+					}
 				}
 			}
 		}
@@ -235,25 +266,11 @@ public void ExecuteMultiReader(string commandText, Action<DbParameterBuilder> pa
 
 		public int ExecuteNonQuery(string commandText, int commandTimeout, CommandType commandType, Action<DbParameterBuilder> parametersBuilder)
 		{
-			int nAffectedRows = 0;
+			int recordsAffected;
 
-			for (int retry = 0; ; retry++)
-			{
-				try
-				{
-					nAffectedRows = CreateCommand(commandText, commandTimeout, commandType, parametersBuilder).ExecuteNonQuery();
-					break;
-				}
-				catch (Exception e)
-				{
-					if (retry < _MaxRetryCount && OnConnectionLost(e))
-						ReConnect(retry);
-					else
-						throw;
-				}
-			}
+			InternalExecute(commandText, commandTimeout, commandType, parametersBuilder, 0, out recordsAffected);
 
-			return nAffectedRows;
+			return recordsAffected;
 		}
 
 		public int ExecuteNonQuery(string commandText, Action<DbParameterBuilder> parametersBuilder = null)
@@ -263,16 +280,12 @@ public int ExecuteNonQuery(string commandText, Action<DbParameterBuilder> parame
 
 		#endregion
 
-		private void ReConnect(int retrying)
+		private void ReConnect()
 		{
 			if (_Connection != null)
 				if (_Connection.State != ConnectionState.Closed)
 				{
 					_Connection.Close();
-
-					if (retrying > 0)
-						Thread.Sleep(retrying * _IncreasingDelayRetry);	// retrying starts at 0, increases delay time for every retry.
-
 					_Connection.Open();
 				}
 		}

DataAccess/DbAccess.slot.cs

@@ -5,20 +5,20 @@ namespace DbParallel.DataAccess
 {
 	partial class DbAccess
 	{
-		partial void OnOracleConnectionLost(Exception dbException, ref bool canRetry, ref bool processed);
-		partial void OnSqlConnectionLost(Exception dbException, ref bool canRetry, ref bool processed);
-		private bool OnConnectionLost(Exception dbException)
+		partial void OnOracleContextLost(Exception dbException, ref RetryAction retryAction, ref bool processed);
+		partial void OnSqlContextLost(Exception dbException, ref RetryAction retryAction, ref bool processed);
+		private RetryAction OnContextLost(Exception dbException)
 		{
-			bool canRetry = false;
+			RetryAction retryAction = RetryAction.None;
 			bool hasBeenProcessed = false;
 
 			if (_TransactionManager.Transaction == null)
 			{
-				OnOracleConnectionLost(dbException, ref canRetry, ref hasBeenProcessed);
-				OnSqlConnectionLost(dbException, ref canRetry, ref hasBeenProcessed);
+				OnOracleContextLost(dbException, ref retryAction, ref hasBeenProcessed);
+				OnSqlContextLost(dbException, ref retryAction, ref hasBeenProcessed);
 			}
 
-			return canRetry;
+			return retryAction;
 		}
 
 		partial void OnOracleReaderExecuting(DbCommand dbCmd, int resultSetCnt/* = 1 */, ref bool processed);

DataAccess/Oracle/DbAccess.partial.cs

@@ -16,7 +16,7 @@ namespace DbParallel.DataAccess
 {
 	partial class DbAccess
 	{
-		partial void OnOracleConnectionLost(Exception dbException, ref bool canRetry, ref bool processed)
+		partial void OnOracleContextLost(Exception dbException, ref RetryAction retryAction, ref bool processed)
 		{
 			if (processed)
 				return;
@@ -26,14 +26,24 @@ partial void OnOracleConnectionLost(Exception dbException, ref bool canRetry, re
 				OracleException e = dbException as OracleException;
 
 				if (e == null)
-					canRetry = false;
+					retryAction = RetryAction.None;
 				else
 					switch (e.Number)
 					{
 						case 3113:
-						case 4068: canRetry = true; break;
+						case 4068:
+							retryAction = RetryAction.Reconnect;
+							break;
+						case 6550:
+							if (e.Errors.Count == 1 && e.Message.Contains("PLS-00306: "))
+								retryAction = RetryAction.RefreshParameters;
+							else
+								retryAction = RetryAction.None;
+							break;
 						// To add other cases
-						default: canRetry = false; break;
+						default:
+							retryAction = RetryAction.None;
+							break;
 					}
 
 				processed = true;

DataAccess/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.8.1.5")]
-[assembly: AssemblyFileVersion("1.8.1.5")]
+[assembly: AssemblyVersion("1.8.2.0")]
+[assembly: AssemblyFileVersion("1.8.2.0")]

DataAccess/SqlServer/DbAccess.partial.cs

@@ -5,7 +5,7 @@ namespace DbParallel.DataAccess
 {
 	partial class DbAccess
 	{
-		partial void OnSqlConnectionLost(Exception dbException, ref bool canRetry, ref bool processed)
+		partial void OnSqlContextLost(Exception dbException, ref RetryAction retryAction, ref bool processed)
 		{
 			if (processed)
 				return;
@@ -15,14 +15,21 @@ partial void OnSqlConnectionLost(Exception dbException, ref bool canRetry, ref b
 				SqlException e = dbException as SqlException;
 
 				if (e == null)
-					canRetry = false;
+					retryAction = RetryAction.None;
 				else
 					switch (e.Number)
 					{
 						case 233:
-						case -2: canRetry = true; break;
+						case -2:
+							retryAction = RetryAction.Reconnect;
+							break;
+						case 201:
+						case 8144:
+							retryAction = RetryAction.RefreshParameters;
+							break;
 						// To add other cases
-						default: canRetry = false; break;
+						default: retryAction = RetryAction.None;
+							break;
 					}
 
 				processed = true;