[ENG-8409] fix: better handle errors in celery result backend #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use celery's own "retry on result-backend error" logic
- remove `die_on_unhandled` hack
- new env var: `CELERY_RESULT_BACKEND_MAX_RETRIES` (default 173)
- retry on error caused by `get_or_create` in overlapping
transactions (with less-strict transaction isolation levels)
- port fixes from celery's `BaseKeyValueStoreBackend`:
- avoid clobbering successes with "worker lost" or other errors
- avoid error trying to get non-existent task results
- use celery's `BaseBackend` instead of `BaseDictBackend`
(equivalent for back-compat; let's use the better name)
felliott
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Seems sensible to me. Only question: is there still a possibility that it could die with an unhandled error? If so, is there somewhere you could hang the sentry_sdk.capture_exception() call on there? Not a deal breaker, feel free to ignore if it doesn't make sense or isn't easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
die_on_unhandledhackCELERY_RESULT_BACKEND_MAX_RETRIES(default 173, why not)get_or_createin overlapping transactions (with less-than-strictest transaction isolation levels)BaseKeyValueStoreBackend:BaseBackendinstead ofBaseDictBackend(equivalent for back-compat; let's use the better name)