[CMSDS-3527] Only render "Learn more" link when learnMoreUrl is defined #3769
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-cmsds
changed the title
derek-cmsds
changed the title
derek-cmsds
added
Type: Fixed
tamara-corbalt
approved these changes
Sep 26, 2025
| expect(learnMoreLink.getAttribute('href')).toBe('https://www.google.com/'); | ||
| }); | ||
|
|
||
| describe('when no learnMoreUrl is defined', () => { |
There was a problem hiding this comment.
Nice test! I like that this is scoped inside a dedicated describe block—it adds clarity. We might want to consider more granular groupings like this for better readability across our test suites.
NB: If there are other tests related to this prop, maybe we can generalize the describe name a bit and move them into this block too?
There was a problem hiding this comment.
NB: Just a heads up: we may also want to add this test for the ds-third-party-link web component. Unfortunately, that component doesn’t exist on main yet, but something to keep in mind once it's merged.
jack-ryan-nava-pbc
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
learnMoreprop is optional, however the text/link that the prop applies was displaying whether the prop is applied or not. This PR updates the "Learn more" link to only display whenlearnMoreUrlis defined.How to test
npm startThirdPartyExternalLinkstory in StorybooklearnMoreUrlcontrol value.Checklist
[CMSDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)