Preserve line terminator type when using --crlf and -r #3100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue where the
--crlf
in combination with-r
/--replace
option causes matched lines to have there line terminators changed to\r\n
, consider for example the following Fish shell line:Without this pull request, it prints:
(So
hello
has magically had an\r
added after to it)With my pull request, the above prints:
With this change,
-r '$0'
is now a no-op, i.e.rg
s behaviour is now the same as if it was omitted.(Note that a
\r\n
will still be inserted when the file does not end in a newline of any sort:see issue #3097.)