[MSI v2] - Enable attestation in pop flows #5496
Merged
+363
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Sep 24, 2025
bgavrilMS
reviewed
Sep 24, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
force-pushed
the
gladjohn/attested_flow
branch
from
6a926fb to
1c409a4
Compare
bgavrilMS
reviewed
Sep 25, 2025
...client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForManagedIdentityParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 25, 2025
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
Robbie-Microsoft
requested changes
Sep 25, 2025
...client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForManagedIdentityParameterBuilder.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ApplicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Show resolved
Hide resolved
gladjohn
force-pushed
the
gladjohn/attested_flow
branch
from
1c409a4 to
ae959d9
Compare
bgavrilMS
reviewed
Sep 29, 2025
src/client/Microsoft.Identity.Client/AppConfig/ApplicationConfiguration.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ImdsV2Tests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
77
to
78
| bool useInMemoryKeys = false, | ||
| bool useKeyGuardKeys = false) |
There was a problem hiding this comment.
Can we just use the useKeyGuardKeys = true? And use InMemory if it's passed in as false? Do you see value in using 2 different params?
There was a problem hiding this comment.
this way we know specifically what we are to expect. alternatively, we can pass the key type.
There was a problem hiding this comment.
updated to use key type instead.
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ImdsV2Tests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ImdsV2Tests.cs
Outdated
Show resolved
Hide resolved
Robbie-Microsoft
approved these changes
Sep 29, 2025
gladjohn
commented
Sep 29, 2025
Comment on lines
602
to
605
| var mi = await CreateManagedIdentityAsync(httpManager, useKeyGuardKeys: true).ConfigureAwait(false); | ||
|
|
||
| // CSR for both the probe and the actual request | ||
| httpManager.AddMockHandler(MockHelpers.MockCsrResponse()); |
There was a problem hiding this comment.
updated the comment to
// CreateManagedIdentityAsync does a probe; Add one more CSR response for the actual acquire.
Robbie-Microsoft
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MSI v2] - Enable attestation in pop flows