Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

Fixing the elevator model #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing the elevator model #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d0afe
Fixing Elevator
troyhopwood Oct 25, 2019
0a016c5
fixing spacing.
troyhopwood Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Services/data/devicemodels/elevator-01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"vibration": 10.0,
"vibration_unit": "mm",
"temperature": 75.0,
"temperature_unit": "F"
"temperature_unit": "F",
"moving": true
Copy link
Collaborator

@peterfelts peterfelts Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me think that we don't even use/consume the default state in the JS files here and here when state values are provided in the device-model files.

It would be great if this change included a comment in all the JS files that called out that we don't respect these default values if they're provided in the device model (I assume that is why you added the value here).

},
"Interval": "00:00:10",
"Scripts": [
Expand Down Expand Up @@ -59,4 +60,4 @@
"Path": "StartElevator-method.js"
}
}
}
}