Skip to content

[AutoPR azure-resourcemanager-dashboard]-generated-from-SDK Generation - Java-5112177 #46078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

Configurations: 'specification/dashboard/Dashboard.Management/tspconfig.yaml', API Version: 2024-11-01-preview, SDK Release Type: beta, and CommitSHA: '737d276c61674f351c2d8ff06c69341ee0f7a598' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'

…ig.yaml', API Version: 2024-11-01-preview, SDK Release Type: beta, and CommitSHA: '737d276c61674f351c2d8ff06c69341ee0f7a598' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jul 21, 2025
Copy link
Contributor

github-actions bot commented Jul 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-dashboard

@weidongxu-microsoft
Copy link
Member

/azp run java - dashboard - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

/azp run java - dashboard - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review July 21, 2025 03:40
@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 03:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR contains an auto-generated SDK update for the Azure Dashboard Resource Manager client library, updating from commit 4c09d8bbeea862f6a84a75f703c3a30ed48fc5cc to 737d276c61674f351c2d8ff06c69341ee0f7a598 for API version 2024-11-01-preview. The primary purpose is to fix a bug related to the update operation for ManagedGrafana resources by converting it from a synchronous operation to a long-running operation (LRO) pattern.

Key changes include:

  • Converting ManagedGrafana update operations to use LRO patterns with beginUpdate methods
  • Restructuring the ManagedGrafanaInner class to extend ProxyResource instead of Resource
  • Reordering fluent builder interface stages to make region specification optional in the creation flow

Reviewed Changes

Copilot reviewed 12 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updates commit SHA reference for spec generation
DashboardManagerTests.java Reorders method calls in test to match new fluent interface
azure-resourcemanager-dashboard_metadata.json Updates cross-language definitions mappings
azure-resourcemanager-dashboard_apiview_properties.json Adds beginUpdate method and removes updateWithResponse
ManagedGrafana.java Restructures fluent interface to make region optional in creation flow
ManagedGrafanaImpl.java Updates to use LRO update methods instead of direct updateWithResponse
GrafanasClientImpl.java Implements LRO pattern for update operations
ManagedGrafanaInner.java Changes base class from Resource to ProxyResource
GrafanasClient.java Updates interface to include LRO update methods
SAMPLE.md Reorders method calls to match new fluent interface pattern
README.md Updates version and reorders method calls in code example
CHANGELOG.md Documents the bug fix for ManagedGrafana update operations

@joshelton1 joshelton1 enabled auto-merge (squash) August 1, 2025 17:24
@joshelton1
Copy link
Member

Hi @weidongxu-microsoft @haolingdong-msft @XiaofeiCao @ArthurMa1978

Changes look good, would you be able to approve when you have the time? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants