-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Ml dev - Sync #9386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
achauhan-scc
wants to merge
383
commits into
Azure:ml-dev
Choose a base branch
from
achauhan-scc:ml-dev
base: ml-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ml dev - Sync #9386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r -storage behavior and add --container-storage-version (Azure#9138)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138547011&view=results Last commit: Azure@737b240
….extractall() on `nfd build` command (Azure#9234) * AOSM CLI - Fixing a zip-slip security bug for code that was using tar.extractall() on `nfd build` command * fixing tests * fixing tests * review updates --------- Co-authored-by: Daniel Steven <danielsteven@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138548638&view=results Last commit: Azure@966e8d8
* Workload orchestration 3.1.0 * Update version * Update version * Adding example * Adding example * Removing pem files * Updating api version * Fixing tests * Fixing tests * Backward Compatible --------- Co-authored-by: Atharva <audapure@microsoft.com>
…0.0 ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138573512&view=results Last commit: Azure@d378651
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138664427&view=results Last commit: Azure@8e30da7
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (Azure#8) * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (Azure#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (Azure#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (Azure#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * Update cluster diagnostics image to 1.29.3 (Azure#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (Azure#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove redundant test files --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138674669&view=results Last commit: Azure@e03fa94
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138690044&view=results Last commit: Azure@961d512
* Site cli extension changes * removing beta * Allowing labels deletion * removing beta from version history * Correcting argument * Correcting format * Updated readme * Adding beta to version * Updating service_name file with site entry
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138696727&view=results Last commit: Azure@4a4e750
* Azure Firewall Autoscale Configuration * bump version * update recordings for tests * reset of recordings * Try to fix recording for test_azure_firewall_policy_explicit_proxy * non-dynamic test value * Use sas token key * Remove explicit proxy test
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=138818987&view=results Last commit: Azure@b030b92
…the API. (Azure#9266) * Removing unsupported commands from the managednetworkfabric CLI. * updating history
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=139155356&view=results Last commit: Azure@59ba8a1
mark operations stable update setup.py and HISTORY.rst remove azext.isPreview from azext_metadata.json
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=139171604&view=results Last commit: Azure@2ebf49e
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=139172224&view=results Last commit: Azure@af54e9d
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=139595971&view=results Last commit: Azure@05c62a2
* skip none overrides on localdns profile * update history rst * refactor to process dns overrides func * move overrides function to helper file * apply linter suggestions * add localdnsconfig folder * add more tests * add new json files * add default dns overrides * add more test cases * move tests around, move invalid cases to another file * add back import semver * reorder the existing tests * delete preferred mode only * delete null.json * remove redundant json file * remove redundant json file * fix the mistake at line 3349 * forgot that i put all the configs in data/localconfig folder * remove unused file * spelling error * fix default dnsOverrides check when we create agentpool with required mode only * restore localdnsconfig file * delete extra property case from invalid test file * add extra property cases in src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py * add extra property files * check for defaulted *dnsOverrides when making agent pool with mode: required only * comment out cleanup in test_aks_nodepool_add_with_localdns_required_mode * add more logging for debugging * add print statements in src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/operations/_agent_pools_operations.py for debugging * only initialize the dictionaries if dnsoverrides are provided * process dns overrides only when dns overrides are provided * consolidate duplicated build_localdns_profile function * move invalid cases to line 4133 * update test_aks_commands.py * look for vnetDnsOverrides and kubeDNSOverrides keys, case-insensitive * fix test_aks_nodepool_add_with_localdns_required_mode_single_vnetdns * check for dictionary for build_override * update failing test cases * rename from required_mode_extra_property.json -> required_mode_kubedns_extra_property.json * fix azdev style * temporarily add self.fail statements s.t. i can see the error_message * change from assertTrue to assertIn with more specific error msg, delete un-needed test case * change from print to debug * remove logger.debug line to print localdnsprofile * add null config file * fix the tests * fix the tests * update src/aks-preview/HISTORY.rst with a new note under 18.0.0b42 * update src/aks-preview/HISTORY.rst * Revert "add print statements in src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/operations/_agent_pools_operations.py for debugging" This reverts commit b747438. * update src/aks-preview/HISTORY.rst * Revert "add more logging for debugging" This reverts commit 1786254. * mix the casing for *dnsoverrides * throw an exception from cli if the values of kubednsoverrides or vnetdnsoverrides are not type dict * add tests for null and non-dict overrides * make the keys of localdnsprofile mixed-case * add required_mode_null_dnsOverrides.json and required_mode_number_dnsOverrides.json * correct the error message I'm looking for, for non-dict dns overrides * remove print stmt from src/aks-preview/azext_aks_preview/_helpers.py * add check for DNS override settings * update the test with dns override settings check * update assertIn msg for test_aks_nodepool_add_with_localdns_required_mode_partial_invalid * break down InvalidArgumentValueError msg into two lines * update existing cassette files * new cassette files for new tests * add three additional cassette files I did not commit before * expect InvalidArgumentValueError when None is provided for DNS overrides * update AKSPreviewAgentPoolUpdateDecoratorCommonTestCase.common_update_localdns_profile * revert the import statement for from azure.cli.command_modules.acs.tests.latest.mocks import * Add a new line * Revert "Add a new line" This reverts commit 2c347c3. * update version in src/aks-preview/setup.py to align with azure-cli-extensions/src/aks-preview/HISTORY.rst --------- Co-authored-by: juanbe <juanbe@microsoft.com> Co-authored-by: Juan Diego Bencardino <jdbencardinop@unal.edu.co>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=144757780&view=results Last commit: Azure@8609ef5
…ersion unsupported media type error (Azure#9445) * Fix: Add Content-Type header to get-version-code command - Added Content-Type: application/json header to POST request - Expanded Accept header to include text/plain and */* for better compatibility - Resolves 'Unsupported Media Type' error when calling get-version-code - Added test case for get-version-code command The fix ensures proper HTTP headers are sent for the getVersionCode operation, which is a POST request with no body. Some Azure services require both Content-Type and Accept headers to be present even for empty-body requests. * Fix 415 Unsupported Media Type for POST operations in edge-action extension - Add Content-Type and Accept headers to get-version-code and swap-default POST operations - Add empty JSON body '{}' required by the API for POST operations without payload - Add --output-directory parameter to get-version-code to decode and save zip files - Comment out execution-filter CRUD test (service returns HTTP URLs in LRO headers, needs service-side fix) - Re-record all passing tests The root cause was that AAZ-generated code for POST operations without a request body was not sending Content-Type header or empty body, causing the API to reject with 415. * Bump version to 1.0.0b2 --------- Co-authored-by: Danny Tundwe (from Dev Box) <dannytundwe@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=144845648&view=results Last commit: Azure@fe10f0e
… caused by PR #9834. (Azure#9448) * Fix issue to AKS restores caused by #9834. * Add version * Fix azdev style --------- Co-authored-by: Zubair Abid <zubairabid@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145171133&view=results Last commit: Azure@9f39214
Azure#9452) * [Release] Add support for AKS backup configuration modification * [Release] Update version to 1.8.0 and nit fixes * azdev style fixes * Modify AKS backup configuration parameter * Fix typos and improve error messages for AKS backup configuration handling * Refactor AKS backup configuration initialization * Update AKS backup configuration argument options * Update AKS backup instance configuration in tests
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145650910&view=results Last commit: Azure@352e030
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145675157&view=results Last commit: Azure@d87a3e7
…e#9454) * update sdk * update history * update recordings
* new generated azure cli for oracle database * linter exclusion * tests and recordings * tests and recordings * tests and recordings * examples * remove secrets * version update * add example for db system * add example for oracle subscription * removed default * removed default * added license to new tests * tets recordings * tets recordings * change logs and readme updated
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145871875&view=results Last commit: Azure@cbda5a9
Co-authored-by: Ketki <ketkinaik@microsoft.com>
* cleanup evals and UTs * add vendored_sdks * containerized aks agent * add UT * update doc and release history * fix style check errors * update chart repo and version * remove wrong file and update default cluster role rule * address comments * dont expose api key in configmap * add init file for vendored_sdks/azure_mgmt_containerservice * fix(windows): fix import fcntl failure on windows * fix(windows): use tempfile library * fix(windows): pick correct helm.exe in zip for windows * remove unused import * bump helm version
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146028638&view=results Last commit: Azure@d08119a
* Remove the depedency on OPA * Bump version * Organise imports
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146293397&view=results Last commit: Azure@084bac7
Co-authored-by: Brian Kimutai <briankimutai@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146301846&view=results Last commit: Azure@2979f01
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146302359&view=results Last commit: Azure@4fd8402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.