Update rtmt.py - pop gives the error when there are two message in the queue #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e queue and there will be index out of range index out of the range. consider two message are in the queue and poping both like total size is 2 pop(1) - it will remove the first element and size becomes 1 pop(2) - it will try to remove the 2nd element but size is 1 and it will be index out of bounds
|
@pamelafox - can you approve this ? |
Michenux
reviewed
May 19, 2025
| if output["type"] == "function_call": | ||
| message["response"]["output"].pop(i) | ||
| original_index = output_len - 1 - reverse_index # Map reversed index to the original |
There was a problem hiding this comment.
output_len ? where is it declared and initialized ?
There was a problem hiding this comment.
thank you for reviewing my PR. Apologies missed to add the declaration earlier. Its now resolved. and updated my PR.
missed to add output_len variable declaration.
| if output["type"] == "function_call": | ||
| message["response"]["output"].pop(i) | ||
| original_index = output_len - 1 - reverse_index # Map reversed index to the original |
There was a problem hiding this comment.
thank you for reviewing my PR. Apologies missed to add the declaration earlier. Its now resolved. and updated my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rtmt.py - pop gives the error when there are two message in the queue and there will be index out of range
index out of the range.
Consider two message are in the queue and poping both like
total size is 2
pop(1) - it will remove the first element and size becomes 1
pop(2) - it will try to remove the 2nd element but size is 1 and it will be index out of bounds