Jetpack Search purchase flow: Allow 'enter' key form submission during purchase flow #104885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses the UX issue raised in #54344 by making it possible to use the 'enter' key to submit the form at `/purchase-product/jetpack_search/monthly`. Because `components/suggestion-search/index.jsx` was modified, this change also impacts any form that uses this component, meaning that 'enter' key submission would not be limited to only the `/purchase-product/jetpack_search/monthly` flow. Attempts to limit the context of this change proved more involved than anticipated, and if 'enter' key submission is a UX concern for the Jetpack Search purchase flow, then I would expect it to be a concern for similar flows elsewhere and so limiting the change is probably not warranted.
anaemnesis
commented
Jul 23, 2025
Comment on lines
-98
to
-105
| getSuggestionLabel( suggestionPosition ) { | ||
| return this.suggestionsRef.props.suggestions[ suggestionPosition ].label; | ||
| } | ||
|
|
||
| updateFieldFromSuggestion( newValue ) { | ||
| this.updateInputValue( newValue ); | ||
| this.props.onChange( newValue, true ); | ||
| } |
anaemnesis
added
[Status] Needs Review
|
@Automattic/red I'm not quite sure who to request for review on this. Would someone on the team have availability, or be able to suggest a better someone to reach out to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Addresses #54344
This PR enables the use of the
Enterkey to submit the form at/purchase-product/jetpack_search/monthly.Note
Because
components/suggestion-search/index.jsxis modified, this change also impacts any form that uses this component, meaning thatEnterkey submission would not be limited to only the form shown through the/purchase-product/jetpack_search/monthlyflow. I looked into limiting the change to the one form, but ifEnterkey submission is a UX/QoL concern for the Jetpack Search purchase flow, then I would expect it to be a concern for similar flows elsewhere, and so we wouldn't want to limit this change.Why are these changes being made?
This addresses a UX/QoL concern. As a user, I would expect to be able to press
Entertwice when going through this purchase flow — once to select my site from the Site Search field and again to submit the form itself via theGet Searchbutton. Right now, pressingEnterto select my site preventsEnterbeing used again to submit the form.Testing Instructions
/purchase-product/jetpack_search/monthlyand begin to type your site's URLEnterto select the suggested siteEnteragain to submit the Jetpack SearchGet Searchformenterkey pressesConfirm no unexpected behaviour at the other paths impacted by this change:
/purchase-product/jetpack_search/purchase-product/jetpack_search/monthly/purchase-product/wpcom_search/purchase-product/wpcom_search/monthlyConfirm Jetpack connection flow is not impacted, including:
/jetpack/connect//jetpack/connect/searchPre-merge Checklist