Skip to content

Connect Refresh: one-login-footer #104883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Jul 23, 2025

Part of https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment

Proposed Changes

  • Removes unnecessary overrides to the Login footer that should be unified
  • Cleans up CSS classes to reduce specificity in the type of links rendered in the footer
  • Cleans up components and usage to a OneLoginFooter component

This doesn't address https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment fully, which seeks to centralise the footer into the OneLoginLayout component. But we at least have a OneLoginFooter component now that we can work with on top.

Media

Main Lost Password Magic Login
Screenshot 2025-07-24 at 12 39 53 PM Screenshot 2025-07-24 at 12 39 59 PM Screenshot 2025-07-24 at 12 40 07 PM

Why are these changes being made?

Part of https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment

Testing Instructions

  • Go to various Login screens (and Gravatar) and confirm the footer renders correctly with correct links
  • Confirm both main Login, Lost-Password, and Magic-Login screens

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds self-assigned this Jul 23, 2025
Copy link

github-actions bot commented Jul 23, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-login       -109 B  (-0.0%)       -4 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds force-pushed the update/connect-refresh-login-footer-abstract branch from 3da7679 to c6dcee5 Compare July 24, 2025 09:36
@chriskmnds chriskmnds marked this pull request as ready for review July 24, 2025 09:42
@chriskmnds chriskmnds requested review from a team and Copilot July 24, 2025 09:42
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 24, 2025
@chriskmnds chriskmnds requested a review from raicem July 24, 2025 09:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request consolidates login footer components across different login screens by introducing a unified OneLoginFooter component and cleaning up CSS specificity. The changes remove duplicate footer styling and standardize the CSS class names used for footer links.

  • Introduces a new OneLoginFooter component to replace the previous LoginBlockFooter
  • Standardizes CSS class names from various specific selectors to a unified one-login__footer-link class
  • Removes duplicate CSS rules and overrides from multiple stylesheet files

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
client/login/wp-login/style.scss Removes old footer CSS rules that are now centralized
client/login/wp-login/index.jsx Updates imports and class names to use the new OneLoginFooter component
client/login/wp-login/components/one-login-footer.tsx Renames component and props, updates class names and structure
client/login/wp-login/components/one-login-footer.scss Creates new centralized stylesheet for the unified footer component
client/login/magic-login/index.jsx Updates magic login to use the new OneLoginFooter component
client/layout/masterbar/woo.scss Removes Woo-specific footer overrides that are no longer needed
client/layout/masterbar/blaze-pro.scss Removes Blaze Pro-specific footer overrides that are no longer needed

{ linkBack }
</a>
</div>
<OneLoginFooter
Copy link
Preview

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OneLoginFooter component expects both lostPasswordLink and loginLink props based on the interface, but only loginLink is being passed here. This could cause runtime issues if the component tries to access the missing lostPasswordLink prop.

Copilot uses AI. Check for mistakes.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/connect-refresh-login-footer-abstract on your sandbox.

Copy link
Contributor

@raicem raicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested login, magic link, and password reset pages for WordPress.com, Jetpack and Woo. All works as described, thank you @chriskmnds!

I left one comment about a type, but it can be considered a nitpick and not a big blocker for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants