-
Notifications
You must be signed in to change notification settings - Fork 2k
Connect Refresh: one-login-footer #104883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~4 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
3da7679
to
c6dcee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request consolidates login footer components across different login screens by introducing a unified OneLoginFooter
component and cleaning up CSS specificity. The changes remove duplicate footer styling and standardize the CSS class names used for footer links.
- Introduces a new
OneLoginFooter
component to replace the previousLoginBlockFooter
- Standardizes CSS class names from various specific selectors to a unified
one-login__footer-link
class - Removes duplicate CSS rules and overrides from multiple stylesheet files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
client/login/wp-login/style.scss | Removes old footer CSS rules that are now centralized |
client/login/wp-login/index.jsx | Updates imports and class names to use the new OneLoginFooter component |
client/login/wp-login/components/one-login-footer.tsx | Renames component and props, updates class names and structure |
client/login/wp-login/components/one-login-footer.scss | Creates new centralized stylesheet for the unified footer component |
client/login/magic-login/index.jsx | Updates magic login to use the new OneLoginFooter component |
client/layout/masterbar/woo.scss | Removes Woo-specific footer overrides that are no longer needed |
client/layout/masterbar/blaze-pro.scss | Removes Blaze Pro-specific footer overrides that are no longer needed |
{ linkBack } | ||
</a> | ||
</div> | ||
<OneLoginFooter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OneLoginFooter component expects both lostPasswordLink
and loginLink
props based on the interface, but only loginLink
is being passed here. This could cause runtime issues if the component tries to access the missing lostPasswordLink
prop.
Copilot uses AI. Check for mistakes.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tested login, magic link, and password reset pages for WordPress.com, Jetpack and Woo. All works as described, thank you @chriskmnds!
I left one comment about a type, but it can be considered a nitpick and not a big blocker for merging
Part of https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment
Proposed Changes
OneLoginFooter
componentThis doesn't address https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment fully, which seeks to centralise the footer into the
OneLoginLayout
component. But we at least have aOneLoginFooter
component now that we can work with on top.Media
Why are these changes being made?
Part of https://linear.app/a8c/issue/DOTCOM-13832/login-pass-login-footer-into-oneloginlayout-component-for-alignment
Testing Instructions
Pre-merge Checklist