Skip to content

AI Client: Fix Jetpack AI upgrade links on block editor #44405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025

Conversation

dhasilva
Copy link
Contributor

Fixes JPAI-64

Proposed changes:

The links on the block editor are not working unless the link text is wrapped in, e.g., a span tag.
This fixes the upgrade links for Jetpack AI by adding the wrapper.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1753132767396529-slack-CDLH4C1UZ

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Either use a new site and make 1 Jetpack AI request or simulate a new site by sandboxing the public API and use the following snippets:
add_filter( 'jetpack_ai_current_period_requests_count', function() { return 1; } );
add_filter( 'jetpack_ai_all_time_requests_count', function() { return 1; } );
add_filter( 'jetpack_ai_tier_licensed_quantity', function() { return 0; } );
  • Now go to a paragraph an open the AI Assistant:
2025-07-21_18-39 * Now click on "Upgrade now": 2025-07-21_18-40 * Check that you are sent to the Jetpack AI upgrade page in another tab

@dhasilva dhasilva requested a review from a team July 21, 2025 21:41
@dhasilva dhasilva self-assigned this Jul 21, 2025
@dhasilva dhasilva added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Jul 21, 2025
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack-ai-upgrade-link branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack-ai-upgrade-link

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented Jul 21, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@dhasilva dhasilva force-pushed the fix/jetpack-ai-upgrade-link branch from 250b06d to 6ff0a59 Compare July 24, 2025 21:09
@github-actions github-actions bot added [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jul 24, 2025
@dhasilva dhasilva merged commit 80cf0b3 into trunk Jul 24, 2025
67 checks passed
@dhasilva dhasilva deleted the fix/jetpack-ai-upgrade-link branch July 24, 2025 21:24
@github-actions github-actions bot added this to the jetpack/14.9 milestone Jul 24, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant