Skip to content

reworked copy/move methods to include "avoid_clashes" feature #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Feb 13, 2025

Added ability to specify and 'avoid_clashes' arg to copy and move methods to add an incrementing counter (e.g. 'file.txt' -> 'file (1).txt') to filenames

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 76.38889% with 17 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (1aa60ea) to head (0e3fa13).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/core/fileset.py 76.38% 10 Missing and 7 partials ⚠️

❌ Your patch status has failed because the patch coverage (76.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   91.68%   91.80%   +0.11%     
==========================================
  Files          47       47              
  Lines        5306     5332      +26     
  Branches      391      398       +7     
==========================================
+ Hits         4865     4895      +30     
+ Misses        335      329       -6     
- Partials      106      108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit cfd67f2 into main Feb 13, 2025
16 of 17 checks passed
@tclose tclose deleted the avoid-clashes branch February 17, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant