Skip to content

Remove an assert from updateSelectedIndex method #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Remove an assert from updateSelectedIndex method #328

merged 1 commit into from
Nov 28, 2024

Conversation

AhmedLSayed9
Copy link
Owner

@AhmedLSayed9 AhmedLSayed9 commented Nov 28, 2024 •
edited
Loading

We're removing the assert from updateSelectedIndex method as it'll throw if valueListenable changes but DropdownButton2 is no longer in the tree. We already use _uniqueValueAssert instead, which gets invoked properly inside ValueListenableBuilder.

@AhmedLSayed9 AhmedLSayed9 added the enhancement New feature or request label Nov 28, 2024
@AhmedLSayed9 AhmedLSayed9 merged commit 5a75ba7 into master Nov 28, 2024
1 check passed
@AhmedLSayed9 AhmedLSayed9 deleted the remove_an_assert branch November 28, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AhmedLSayed9