Add HTTP Method as a Parameter for APIs that support POST #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s3714110 would it be possible to add some test cases for the POST method? |
yashvardhannanavati
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding extra method parameter for PrometheusConnect class (default is GET), so that users can toggle to use POST for Prometheus APIs that support it, such as /query, /query_range and /labels, as some prefer POST due to it being able to handle larger and more complex queries.
Other APIs, such as /label/{1}/values, /targets, /targets/metadata and /metadata, will still only use GET method and are not affected by the method parameter. I also switch to use request() method for the session object across all requests to make it consistent.
I used the official Prometheus documentation as the main reference: https://prometheus.io/docs/prometheus/latest/querying/api/