Skip to content

Commit 7ff0c68

Browse files
committed
drivers: modem: generalize Quectel BG9X support
Replace specific reference for Quectel BG95 in Modem Cellular with BG9x, since the setup code should apply for other members of this family. Rename the 'quectel,bg95' DTS binding to 'quectel,bg9x' and add optional 'mdm-reset-gpios' property. To avoid confusion, delete the old 'quectel,bg9x' DTS binding and its implementation. Signed-off-by: Guilherme Costa <guilhermecosta@stratioautomotive.com>
1 parent d84348f commit 7ff0c68

File tree

5 files changed

+17
-166
lines changed

5 files changed

+17
-166
lines changed

drivers/modem/Kconfig.cellular

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ config MODEM_CELLULAR
1414
select NET_L2_PPP_OPTION_MRU
1515
select NET_L2_PPP_PAP
1616
select NET_L2_PPP_MGMT
17-
depends on (DT_HAS_QUECTEL_BG95_ENABLED || DT_HAS_SIMCOM_A76XX_ENABLED || \
17+
depends on (DT_HAS_QUECTEL_BG9X_ENABLED || DT_HAS_SIMCOM_A76XX_ENABLED || \
1818
DT_HAS_SIMCOM_SIM7080_ENABLED || DT_HAS_U_BLOX_SARA_R4_ENABLED || \
1919
DT_HAS_U_BLOX_SARA_R5_ENABLED || DT_HAS_SWIR_HL7800_ENABLED || \
2020
DT_HAS_TELIT_ME910G1_ENABLED || DT_HAS_TELIT_ME310G1_ENABLED || \

drivers/modem/modem_cellular.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,8 +1939,8 @@ static int modem_cellular_init(const struct device *dev)
19391939
* dial out and put the DLCI channel into data mode.
19401940
*/
19411941

1942-
#if DT_HAS_COMPAT_STATUS_OKAY(quectel_bg95)
1943-
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg95_init_chat_script_cmds,
1942+
#if DT_HAS_COMPAT_STATUS_OKAY(quectel_bg9x)
1943+
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_init_chat_script_cmds,
19441944
MODEM_CHAT_SCRIPT_CMD_RESP("ATE0", ok_match),
19451945
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=4", ok_match),
19461946
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CMEE=1", ok_match),
@@ -1964,27 +1964,27 @@ MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg95_init_chat_script_cmds,
19641964
MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match),
19651965
MODEM_CHAT_SCRIPT_CMD_RESP_NONE("AT+CMUX=0,0,5,127", 300));
19661966

1967-
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg95_init_chat_script, quectel_bg95_init_chat_script_cmds,
1967+
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_init_chat_script, quectel_bg9x_init_chat_script_cmds,
19681968
abort_matches, modem_cellular_chat_callback_handler, 10);
19691969

1970-
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg95_dial_chat_script_cmds,
1970+
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_dial_chat_script_cmds,
19711971
MODEM_CHAT_SCRIPT_CMD_RESP_MULT("AT+CGACT=0,1", allow_match),
19721972
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CGDCONT=1,\"IP\","
19731973
"\""CONFIG_MODEM_CELLULAR_APN"\"",
19741974
ok_match),
19751975
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=1", ok_match),
19761976
MODEM_CHAT_SCRIPT_CMD_RESP("ATD*99***1#", connect_match));
19771977

1978-
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg95_dial_chat_script, quectel_bg95_dial_chat_script_cmds,
1978+
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_dial_chat_script, quectel_bg9x_dial_chat_script_cmds,
19791979
dial_abort_matches, modem_cellular_chat_callback_handler, 10);
19801980

1981-
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg95_periodic_chat_script_cmds,
1981+
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_periodic_chat_script_cmds,
19821982
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CREG?", ok_match),
19831983
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CEREG?", ok_match),
19841984
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CGREG?", ok_match));
19851985

1986-
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg95_periodic_chat_script,
1987-
quectel_bg95_periodic_chat_script_cmds, abort_matches,
1986+
MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_periodic_chat_script,
1987+
quectel_bg9x_periodic_chat_script_cmds, abort_matches,
19881988
modem_cellular_chat_callback_handler, 4);
19891989
#endif
19901990

@@ -2652,7 +2652,7 @@ MODEM_CHAT_SCRIPT_DEFINE(sqn_gm02s_periodic_chat_script,
26522652
&MODEM_CELLULAR_INST_NAME(config, inst), POST_KERNEL, 99, \
26532653
&modem_cellular_api);
26542654

2655-
#define MODEM_CELLULAR_DEVICE_QUECTEL_BG95(inst) \
2655+
#define MODEM_CELLULAR_DEVICE_QUECTEL_BG9X(inst) \
26562656
MODEM_PPP_DEFINE(MODEM_CELLULAR_INST_NAME(ppp, inst), NULL, 98, 1500, 64); \
26572657
\
26582658
static struct modem_cellular_data MODEM_CELLULAR_INST_NAME(data, inst) = { \
@@ -2667,9 +2667,9 @@ MODEM_CHAT_SCRIPT_DEFINE(sqn_gm02s_periodic_chat_script,
26672667
\
26682668
MODEM_CELLULAR_DEFINE_INSTANCE(inst, 1500, 100, 10000, 5000, false, \
26692669
NULL, \
2670-
&quectel_bg95_init_chat_script, \
2671-
&quectel_bg95_dial_chat_script, \
2672-
&quectel_bg95_periodic_chat_script, NULL)
2670+
&quectel_bg9x_init_chat_script, \
2671+
&quectel_bg9x_dial_chat_script, \
2672+
&quectel_bg9x_periodic_chat_script, NULL)
26732673

26742674
#define MODEM_CELLULAR_DEVICE_QUECTEL_EG25_G(inst) \
26752675
MODEM_PPP_DEFINE(MODEM_CELLULAR_INST_NAME(ppp, inst), NULL, 98, 1500, 64); \
@@ -2899,8 +2899,8 @@ MODEM_CHAT_SCRIPT_DEFINE(sqn_gm02s_periodic_chat_script,
28992899
&sqn_gm02s_dial_chat_script, \
29002900
&sqn_gm02s_periodic_chat_script, NULL)
29012901

2902-
#define DT_DRV_COMPAT quectel_bg95
2903-
DT_INST_FOREACH_STATUS_OKAY(MODEM_CELLULAR_DEVICE_QUECTEL_BG95)
2902+
#define DT_DRV_COMPAT quectel_bg9x
2903+
DT_INST_FOREACH_STATUS_OKAY(MODEM_CELLULAR_DEVICE_QUECTEL_BG9X)
29042904
#undef DT_DRV_COMPAT
29052905

29062906
#define DT_DRV_COMPAT quectel_eg25_g

drivers/modem/quectel-bg9x.h

Lines changed: 0 additions & 130 deletions
This file was deleted.

dts/bindings/modem/quectel,bg95.yaml

Lines changed: 0 additions & 12 deletions
This file was deleted.

dts/bindings/modem/quectel,bg9x.yaml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# Copyright (c) 2020 Analog Life LLC
1+
# Copyright (c) 2023 Bjarki Arge Andreasen
22
# SPDX-License-Identifier: Apache-2.0
33

4-
description: quectel BG9x modem
4+
description: Quectel BG9X modems
55

66
compatible: "quectel,bg9x"
77

@@ -10,13 +10,6 @@ include: uart-device.yaml
1010
properties:
1111
mdm-power-gpios:
1212
type: phandle-array
13-
required: true
1413

1514
mdm-reset-gpios:
1615
type: phandle-array
17-
18-
mdm-dtr-gpios:
19-
type: phandle-array
20-
21-
mdm-wdisable-gpios:
22-
type: phandle-array

0 commit comments

Comments
 (0)