Skip to content

Commit a92170c

Browse files
author
Andrei Kamarouski
committed
Add opportunity to enable silent driver failure
1 parent ee4762e commit a92170c

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

src/main/java/com/zebrunner/agent/core/config/ConfigurationHolder.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ public static boolean shouldSubstituteRemoteWebDrivers() {
8080
return substituteRemoteWebDrivers != null && substituteRemoteWebDrivers;
8181
}
8282

83+
public static boolean silentDriverFailure() {
84+
Boolean silentDriverFailure = configuration.getRun().getSilentDriverFailure();
85+
return silentDriverFailure != null && silentDriverFailure;
86+
}
87+
8388
public static boolean shouldTreatSkipsAsFailures() {
8489
Boolean treatSkipsAsFailures = configuration.getRun().getTreatSkipsAsFailures();
8590
return treatSkipsAsFailures == null || treatSkipsAsFailures;

src/main/java/com/zebrunner/agent/core/config/ReportingConfiguration.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,12 @@ public static class RunConfiguration {
128128
@EnvironmentVariable("REPORTING_RUN_SUBSTITUTE_REMOTE_WEB_DRIVERS")
129129
private Boolean substituteRemoteWebDrivers;
130130

131+
@YamlProperty("reporting.run.silent-driver-failure")
132+
@EnvironmentVariable("REPORTING_RUN_SILENT_DRIVER_FAILURE")
133+
@PropertiesFileProperty("reporting.run.silent-driver-failure")
134+
@SystemProperty({"reporting.run.silent-driver-failure", "reporting.run.silent-driver-failure"})
135+
private Boolean silentDriverFailure;
136+
131137
@YamlProperty("reporting.run.treat-skips-as-failures")
132138
@SystemProperty("reporting.run.treat-skips-as-failures")
133139
@EnvironmentVariable("REPORTING_RUN_TREAT_SKIPS_AS_FAILURES")

src/main/java/com/zebrunner/agent/core/webdriver/StartSessionInterceptor.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import com.zebrunner.agent.core.config.ConfigurationHolder;
44
import com.zebrunner.agent.core.registrar.TestSessionRegistrar;
55
import com.zebrunner.agent.core.registrar.descriptor.SessionStartDescriptor;
6+
import com.zebrunner.agent.core.registrar.descriptor.Status;
7+
import com.zebrunner.agent.core.registrar.domain.TestSessionDTO;
68
import lombok.extern.slf4j.Slf4j;
79
import net.bytebuddy.implementation.bind.annotation.Argument;
810
import net.bytebuddy.implementation.bind.annotation.RuntimeType;
@@ -68,7 +70,11 @@ public static void onSessionStart(@This RemoteWebDriver driver,
6870
startDescriptor.failedToStart(errorMessageStringWriter.toString());
6971
throw e;
7072
} finally {
71-
REGISTRAR.registerStart(startDescriptor);
73+
if(!ConfigurationHolder.silentDriverFailure() ||
74+
(ConfigurationHolder.silentDriverFailure() &&
75+
TestSessionDTO.Status .RUNNING.equals(startDescriptor.getStatus()))) {
76+
REGISTRAR.registerStart(startDescriptor);
77+
}
7278
}
7379
}
7480

0 commit comments

Comments
 (0)