Skip to content

Commit 7f89a1e

Browse files
committed
Avoid dangerous try/except/pass pattern on Ravel connection
1 parent 96a1929 commit 7f89a1e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

resources/lib/dbus_pulseaudio.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# SPDX-License-Identifier: GPL-2.0
22
# Copyright (C) 2020-present Team LibreELEC
33

4+
import traceback
5+
import log
46
import dbus_utils
57
import dbussy
68
import ravel
@@ -54,4 +56,5 @@ def call_method(bus_name, path, interface, method_name, *args, **kwargs):
5456
conn.bus_unique_name = 'PulseAudio'
5557
BUS = ravel.Connection(conn, False)
5658
except Exception as e:
57-
pass
59+
log.log('pulseaudio module; init fail: ' + str(e), log.ERROR)
60+
log.log(traceback.format_exc(), log.ERROR)

0 commit comments

Comments
 (0)