feat: fix validate

Author: yogeshpaliyal

.github/workflows/validate.yml

@@ -8,6 +8,11 @@ on:
   # Allow manual triggering of the workflow
   workflow_dispatch:
 
+# Add explicit permissions for the GITHUB_TOKEN
+permissions:
+  contents: read
+  pull-requests: write # Required to add comments to PRs
+
 jobs:
   validate:
     runs-on: ubuntu-latest
@@ -29,21 +34,13 @@ jobs:
       - name: Run merge test
         run: bun run node scripts/merge.js
 
-      - name: Add validation status comment
-        if: always()
-        uses: actions/github-script@v6
+      # Option 1: Use a dedicated action for PR comments instead
+      - name: Add PR comment
+        if: github.event_name == 'pull_request' && always()
+        uses: marocchino/sticky-pull-request-comment@v2
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const conclusion = "${{ job.status }}";
-            const emoji = conclusion === "success" ? "✅" : "❌";
-            const message = conclusion === "success" 
-              ? "All data files are valid!" 
-              : "There are issues with the data files. Please check the action logs for details.";
+          header: validation-result
+          message: |
+            ## Data Validation ${{ job.status == 'success' && '✅' || '❌' }}
             
-            github.rest.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: `## Data Validation ${emoji}\n\n${message}`
-            })
+            ${{ job.status == 'success' && 'All data files are valid!' || 'There are issues with the data files. Please check the action logs for details.' }}

bun.lock

@@ -20,6 +20,7 @@
         "@types/react-dom": "^19.0.4",
         "@vitejs/plugin-react-swc": "^3.8.0",
         "ajv": "^8.12.0",
+        "ajv-formats": "^2.1.1",
         "autoprefixer": "^10.4.21",
         "eslint": "^9.22.0",
         "eslint-plugin-react-hooks": "^5.2.0",
@@ -250,6 +251,8 @@
 
     "ajv": ["ajv@8.17.1", "", { "dependencies": { "fast-deep-equal": "^3.1.3", "fast-uri": "^3.0.1", "json-schema-traverse": "^1.0.0", "require-from-string": "^2.0.2" } }, "sha512-B/gBuNg5SiMTrPkC+A2+cW0RszwxYmn6VYxB/inlBStS5nx6xHIt/ehKRhIMhqusl7a8LjQoZnjCs5vhwxOQ1g=="],
 
+    "ajv-formats": ["ajv-formats@2.1.1", "", { "dependencies": { "ajv": "^8.0.0" } }, "sha512-Wx0Kx52hxE7C18hkMEggYlEifqWZtYaRgouJor+WMdPnQyEK13vgEWyVNup7SoeeoLMsr4kf5h6dOW11I15MUA=="],
+
     "ansi-styles": ["ansi-styles@4.3.0", "", { "dependencies": { "color-convert": "^2.0.1" } }, "sha512-zbB9rCJAT1rbjiVDb2hqKFHNYLxgtk8NURxZ3IZwD3F6NtxbXZQCnnSi1Lkx+IDohdPlFp222wVALIheZJQSEg=="],
 
     "argparse": ["argparse@2.0.1", "", {}, "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q=="],

package.json

@@ -27,6 +27,7 @@
     "@types/react-dom": "^19.0.4",
     "@vitejs/plugin-react-swc": "^3.8.0",
     "ajv": "^8.12.0",
+    "ajv-formats": "^2.1.1",
     "autoprefixer": "^10.4.21",
     "eslint": "^9.22.0",
     "eslint-plugin-react-hooks": "^5.2.0",

scripts/validate.js

@@ -2,6 +2,7 @@ import fs from 'fs';
 import path from 'path';
 import { fileURLToPath } from 'url';
 import Ajv from 'ajv';
+import addFormats from 'ajv-formats';
 
 // Get directory name in ES modules
 const __filename = fileURLToPath(import.meta.url);
@@ -20,8 +21,8 @@ const toolSchema = {
     description: { type: 'string', minLength: 10 },
     link: { 
       type: 'string', 
-      format: 'uri',
-      pattern: '^https?://' 
+      // Use pattern instead of format for URL validation
+      pattern: '^https?://[\\w.-]+(\\.[\\w.-]+)+([\\w.,@?^=%&:/~+#-]*[\\w@?^=%&/~+#-])?$'
     },
     tags: { 
       type: 'array', 
@@ -34,6 +35,8 @@ const toolSchema = {
 
 // Initialize Ajv
 const ajv = new Ajv({ allErrors: true });
+// Add format support (optional, since we're using pattern)
+addFormats(ajv);
 const validate = ajv.compile(toolSchema);
 
 // Function to validate a JSON file
@@ -43,6 +46,13 @@ function validateJsonFile(filePath) {
     const fileContent = fs.readFileSync(filePath, 'utf8');
     const data = JSON.parse(fileContent);
 
+    // Basic URL validation (as a fallback)
+    if (!data.link.startsWith('http://') && !data.link.startsWith('https://')) {
+      console.error(`\x1b[31m❌ Validation failed for ${path.basename(filePath)}:\x1b[0m`);
+      console.error(`  - /link must start with http:// or https://`);
+      return false;
+    }
+    
     // Validate against schema
     const valid = validate(data);