Skip to content

Commit a4b9856

Browse files
yogeshpaliyalyogeshpaliyal
authored
Merge pull request #11 from yogeshpaliyal/feature/detekt
Feature/detekt
2 parents a8f1e49 + fc65e4e commit a4b9856

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+253
-209
lines changed

‎.idea/misc.xml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎app/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ apply plugin: 'com.android.application'
22

33
apply plugin: 'kotlin-android'
44
apply plugin: 'kotlin-kapt'
5+
apply plugin: "io.gitlab.arturbosch.detekt"
6+
57

68
android {
79
compileSdkVersion 29

‎app/detekt-baseline.xml

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
<?xml version="1.0" ?>
2+
<SmellBaseline>
3+
<ManuallySuppressedIssues></ManuallySuppressedIssues>
4+
<CurrentIssues>
5+
<ID>EmptyClassBlock:SchoolListing.kt$SchoolListing${ }</ID>
6+
<ID>EmptyDefaultConstructor:BindingTestViewModel.kt$BindingTestViewModel$()</ID>
7+
<ID>MagicNumber:BindingTestViewModel.kt$BindingTestViewModel$3000</ID>
8+
<ID>MagicNumber:LoadingListingViewModel.kt$LoadingListingViewModel$10</ID>
9+
<ID>MagicNumber:LoadingListingViewModel.kt$LoadingListingViewModel$3000</ID>
10+
<ID>MaxLineLength:BindingTestViewModel.kt$BindingTestViewModel$tempArr.add(UserModel(name = "Yogesh",image = "https://randomuser.me/api/portraits/men/52.jpg", address = "Jodhpur"))</ID>
11+
<ID>MaxLineLength:UserListingActivityViewModel.kt$UserListingActivityViewModel$tempArr.add(UserModel(name = "Yogesh",image = "https://randomuser.me/api/portraits/men/52.jpg", address = "Jodhpur"))</ID>
12+
<ID>MaxLineLength:UserModel.kt$UserModel$data</ID>
13+
<ID>NewLineAtEndOfFile:BasicListener.kt$com.techpaliyal.androidkotlinmvvm.listeners.BasicListener.kt</ID>
14+
<ID>NewLineAtEndOfFile:BasicListingActivityViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.BasicListingActivityViewModel.kt</ID>
15+
<ID>NewLineAtEndOfFile:BasicModel.kt$com.techpaliyal.androidkotlinmvvm.model.BasicModel.kt</ID>
16+
<ID>NewLineAtEndOfFile:BindingAdapterTestActivity.kt$com.techpaliyal.androidkotlinmvvm.ui.activity.BindingAdapterTestActivity.kt</ID>
17+
<ID>NewLineAtEndOfFile:BindingTestViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.BindingTestViewModel.kt</ID>
18+
<ID>NewLineAtEndOfFile:HeadingModel.kt$com.techpaliyal.androidkotlinmvvm.ui.multiple_view.HeadingModel.kt</ID>
19+
<ID>NewLineAtEndOfFile:ImageViewExtensions.kt$com.techpaliyal.androidkotlinmvvm.extensions.ImageViewExtensions.kt</ID>
20+
<ID>NewLineAtEndOfFile:ListItemModel.kt$com.techpaliyal.androidkotlinmvvm.ui.multiple_view.ListItemModel.kt</ID>
21+
<ID>NewLineAtEndOfFile:LoadingListingActivity.kt$com.techpaliyal.androidkotlinmvvm.ui.activity.LoadingListingActivity.kt</ID>
22+
<ID>NewLineAtEndOfFile:LoadingListingViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.LoadingListingViewModel.kt</ID>
23+
<ID>NewLineAtEndOfFile:MultiSelectListingActivityViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.MultiSelectListingActivityViewModel.kt</ID>
24+
<ID>NewLineAtEndOfFile:MultiSelectModel.kt$com.techpaliyal.androidkotlinmvvm.model.MultiSelectModel.kt</ID>
25+
<ID>NewLineAtEndOfFile:MultipleViewTypeActivity.kt$com.techpaliyal.androidkotlinmvvm.ui.multiple_view.MultipleViewTypeActivity.kt</ID>
26+
<ID>NewLineAtEndOfFile:MultipleViewTypeViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.multiple_view.MultipleViewTypeViewModel.kt</ID>
27+
<ID>NewLineAtEndOfFile:PaginationListingActivity.kt$com.techpaliyal.androidkotlinmvvm.ui.activity.PaginationListingActivity.kt</ID>
28+
<ID>NewLineAtEndOfFile:RecyclerViewPagination.kt$com.techpaliyal.androidkotlinmvvm.extensions.RecyclerViewPagination.kt</ID>
29+
<ID>NewLineAtEndOfFile:SchoolListing.kt$com.techpaliyal.androidkotlinmvvm.ui.multiple_view.SchoolListing.kt</ID>
30+
<ID>NewLineAtEndOfFile:ShimmerListingActivity.kt$com.techpaliyal.androidkotlinmvvm.ui.activity.ShimmerListingActivity.kt</ID>
31+
<ID>NewLineAtEndOfFile:StringHelper.kt$com.techpaliyal.androidkotlinmvvm.utils.StringHelper.kt</ID>
32+
<ID>NewLineAtEndOfFile:UserListingActivityViewModel.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.UserListingActivityViewModel.kt</ID>
33+
<ID>NewLineAtEndOfFile:UserModel.kt$com.techpaliyal.androidkotlinmvvm.model.UserModel.kt</ID>
34+
<ID>NewLineAtEndOfFile:UsersListener.kt$com.techpaliyal.androidkotlinmvvm.listeners.UsersListener.kt</ID>
35+
<ID>NewLineAtEndOfFile:ViewModelFactory.kt$com.techpaliyal.androidkotlinmvvm.ui.view_model.ViewModelFactory.kt</ID>
36+
<ID>PackageNaming:BasicListingActivityViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
37+
<ID>PackageNaming:BindingTestViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
38+
<ID>PackageNaming:HeadingModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.multiple_view</ID>
39+
<ID>PackageNaming:ListItemModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.multiple_view</ID>
40+
<ID>PackageNaming:LoadingListingViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
41+
<ID>PackageNaming:MultiSelectListingActivityViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
42+
<ID>PackageNaming:MultipleViewTypeActivity.kt$package com.techpaliyal.androidkotlinmvvm.ui.multiple_view</ID>
43+
<ID>PackageNaming:MultipleViewTypeViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.multiple_view</ID>
44+
<ID>PackageNaming:SchoolListing.kt$package com.techpaliyal.androidkotlinmvvm.ui.multiple_view</ID>
45+
<ID>PackageNaming:UserListingActivityViewModel.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
46+
<ID>PackageNaming:ViewModelFactory.kt$package com.techpaliyal.androidkotlinmvvm.ui.view_model</ID>
47+
<ID>UnusedPrivateMember:LoadingListingViewModel.kt$LoadingListingViewModel$i</ID>
48+
<ID>VariableNaming:RecyclerViewPagination.kt$val VISIBLE_THRESHOLD: Int = RECYCLER_PAGING_THRESHOLD</ID>
49+
<ID>WildcardImport:BindingTestViewModel.kt$import androidx.lifecycle.*</ID>
50+
</CurrentIssues>
51+
</SmellBaseline>

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/model/BasicModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.techpaliyal.androidkotlinmvvm.model
22

3-
import com.yogeshpaliyal.universal_adapter.model.BaseDiffUtil
3+
import com.yogeshpaliyal.universalAdapter.model.BaseDiffUtil
44

55
/**
66
* @author Yogesh Paliyal

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/model/MultiSelectModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.techpaliyal.androidkotlinmvvm.model
22

3-
import com.yogeshpaliyal.universal_adapter.model.BaseDiffUtil
3+
import com.yogeshpaliyal.universalAdapter.model.BaseDiffUtil
44

55

66
/**

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/model/UserModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.techpaliyal.androidkotlinmvvm.model
22

3-
import com.yogeshpaliyal.universal_adapter.model.BaseDiffUtil
3+
import com.yogeshpaliyal.universalAdapter.model.BaseDiffUtil
44

55

66
/**

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/ui/activity/BasicListingActivity.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ import com.techpaliyal.androidkotlinmvvm.listeners.BasicListener
1212
import com.techpaliyal.androidkotlinmvvm.model.BasicModel
1313
import com.techpaliyal.androidkotlinmvvm.ui.view_model.BasicListingActivityViewModel
1414
import com.techpaliyal.androidkotlinmvvm.ui.view_model.initViewModel
15-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalAdapterViewType
16-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalRecyclerAdapter
17-
import com.yogeshpaliyal.universal_adapter.utils.Resource
15+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalAdapterViewType
16+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalRecyclerAdapter
17+
import com.yogeshpaliyal.universalAdapter.utils.Resource
1818

1919
/**
2020
* @author Yogesh Paliyal

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/ui/activity/LoadingListingActivity.kt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@ import android.content.Intent
55
import android.os.Bundle
66
import android.widget.Toast
77
import androidx.appcompat.app.AppCompatActivity
8+
import androidx.databinding.ViewDataBinding
89
import androidx.lifecycle.Observer
910
import com.techpaliyal.androidkotlinmvvm.R
1011
import com.techpaliyal.androidkotlinmvvm.databinding.ActivityListingBinding
1112
import com.techpaliyal.androidkotlinmvvm.listeners.BasicListener
13+
import com.techpaliyal.androidkotlinmvvm.listeners.UsersListener
1214
import com.techpaliyal.androidkotlinmvvm.model.UserModel
1315
import com.techpaliyal.androidkotlinmvvm.ui.view_model.LoadingListingViewModel
1416
import com.techpaliyal.androidkotlinmvvm.ui.view_model.initViewModel
15-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalAdapterViewType
16-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalRecyclerAdapter
17+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalAdapterViewType
18+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalRecyclerAdapter
1719

1820
/**
1921
* @author Yogesh Paliyal
@@ -42,7 +44,10 @@ class LoadingListingActivity : AppCompatActivity() {
4244
UniversalRecyclerAdapter.Builder<UserModel>(
4345
lifecycleOwner = this,
4446
content = UniversalAdapterViewType.Content(resource = R.layout.item_user,
45-
object : BasicListener<UserModel> {
47+
object : UsersListener {
48+
override fun onLikeClicked(binding: ViewDataBinding, model: UserModel) {
49+
50+
}
4651
override fun onClick(model: UserModel) {
4752
Toast.makeText(this@LoadingListingActivity, model.name, Toast.LENGTH_SHORT)
4853
.show()

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/ui/activity/MultiSelectListingActivity.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import com.techpaliyal.androidkotlinmvvm.listeners.BasicListener
1111
import com.techpaliyal.androidkotlinmvvm.model.MultiSelectModel
1212
import com.techpaliyal.androidkotlinmvvm.ui.view_model.MultiSelectListingActivityViewModel
1313
import com.techpaliyal.androidkotlinmvvm.ui.view_model.initViewModel
14-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalAdapterViewType
15-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalRecyclerAdapter
16-
import com.yogeshpaliyal.universal_adapter.utils.Resource
14+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalAdapterViewType
15+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalRecyclerAdapter
16+
import com.yogeshpaliyal.universalAdapter.utils.Resource
1717

1818
/**
1919
* @author Yogesh Paliyal

‎app/src/main/java/com/techpaliyal/androidkotlinmvvm/ui/activity/PaginationListingActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import com.techpaliyal.androidkotlinmvvm.listeners.BasicListener
1313
import com.techpaliyal.androidkotlinmvvm.model.UserModel
1414
import com.techpaliyal.androidkotlinmvvm.ui.view_model.LoadingListingViewModel
1515
import com.techpaliyal.androidkotlinmvvm.ui.view_model.initViewModel
16-
import com.yogeshpaliyal.universal_adapter.adapter.UniversalRecyclerAdapter
16+
import com.yogeshpaliyal.universalAdapter.adapter.UniversalRecyclerAdapter
1717

1818
/**
1919
* @author Yogesh Paliyal

0 commit comments

Comments
 (0)