-
Notifications
You must be signed in to change notification settings - Fork 27
Consider id
field addition dangerous
#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sambostock
wants to merge
2
commits into
xuorig:master
Choose a base branch
from
sambostock:id-danger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
test/lib/graphql/schema_comparator/changes/field_added_test.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
require "test_helper" | ||
|
||
class GraphQL::SchemaComparator::Changes::FieldAddedTest < Minitest::Test | ||
def test_criticality_is_non_breaking_by_default | ||
change = GraphQL::SchemaComparator::Changes::FieldAdded.new( | ||
GraphQL::ObjectType.define { name "Type" }, | ||
GraphQL::Field.define { name "field" }, | ||
) | ||
|
||
assert change.non_breaking? | ||
end | ||
|
||
def test_criticality_is_dangerous_for_id_field_addition | ||
change = GraphQL::SchemaComparator::Changes::FieldAdded.new( | ||
GraphQL::ObjectType.define { name "Type" }, | ||
GraphQL::Field.define { name "id" }, | ||
) | ||
|
||
assert change.dangerous? | ||
assert_equal 'this can blow up linters and change caching behaviour', change.message | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it should be possible to customize this?
For instance,
InMemoryCache
looks forid
or_id
by defaultrequired-fields
rule is customizable and usesuuid
in its exampleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I think customizing this might go into "linter" territory? Especially beyond the initial
id
only proposal.Anyone consuming this library is free to do whatever they want with the output of course.