Skip to content

Commit 8192fc7

Browse files
committed
Sonar
1 parent 66da782 commit 8192fc7

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

dynamicreports-core-for-grid-exporter/src/main/java/software/xdev/dynamicreports/design/base/style/DRDesignStyle.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,14 @@ public void addConditionalStyle(final DRDesignConditionalStyle conditionalStyle)
7878
this.conditionalStyles.add(conditionalStyle);
7979
}
8080

81-
@SuppressWarnings("checkstyle:EqualsHashCode")
81+
@SuppressWarnings({"checkstyle:EqualsHashCode", "java:S1206", "java:S2097"}) // Upstream
8282
@Override
8383
public boolean equals(final Object obj)
8484
{
85+
if(obj == null)
86+
{
87+
return false;
88+
}
8589
final EqualsBuilder equalsBuilder = new EqualsBuilder().appendSuper(super.equals(obj));
8690
if(equalsBuilder.isEquals())
8791
{

dynamicreports-core-for-grid-exporter/src/main/java/software/xdev/dynamicreports/jasper/builder/JasperReportBuilder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.util.Collection;
2727
import java.util.HashMap;
2828
import java.util.Map;
29+
import java.util.Objects;
2930

3031
import org.apache.commons.lang3.Validate;
3132

@@ -97,7 +98,7 @@ public JasperReportBuilder()
9798

9899
public JasperReportBuilder setStartPageNumber(final Integer startPageNumber) throws DRException
99100
{
100-
if(this.startPageNumber == startPageNumber)
101+
if(Objects.equals(this.startPageNumber, startPageNumber))
101102
{
102103
return this;
103104
}

dynamicreports-core-for-grid-exporter/src/main/java/software/xdev/dynamicreports/report/builder/condition/ConditionBuilders.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
import software.xdev.dynamicreports.report.definition.DRIValue;
2121

2222

23+
@SuppressWarnings("java:S1221")
2324
public class ConditionBuilders
2425
{
25-
2626
@SuppressWarnings("unchecked")
2727
public <T> EqualExpression equal(final DRIValue<T> value, final T... values)
2828
{

dynamicreports-core-for-grid-exporter/src/main/java/software/xdev/dynamicreports/report/builder/condition/Conditions.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import software.xdev.dynamicreports.report.definition.DRIValue;
2121

2222

23+
@SuppressWarnings("java:S1221")
2324
public final class Conditions
2425
{
2526
private Conditions()

0 commit comments

Comments
 (0)