Routescan returns gas prices in wei (not gwei) and should not inheri… (#1589)

* Routescan returns gas prices in wei (not gwei) and should not inherit parent function

* update Goerli chain ID

Author: Thorian1te

.changeset/angry-drinks-boil.md

@@ -0,0 +1,6 @@
+---
+'@xchainjs/xchain-evm-providers': patch
+'@xchainjs/xchain-arbitrum': patch
+---
+
+Routescan returns gas prices in wei (not gwei) and should not inherit parent function

packages/xchain-arbitrum/src/const.ts

@@ -1,7 +1,7 @@
 // Import necessary modules and classes from external packages and files
 import { ExplorerProvider, Network } from '@xchainjs/xchain-client'
 import { EVMClientParams } from '@xchainjs/xchain-evm'
-import { EtherscanProviderV2 } from '@xchainjs/xchain-evm-providers'
+import { RoutescanProvider } from '@xchainjs/xchain-evm-providers'
 import { Asset, AssetType, TokenAsset } from '@xchainjs/xchain-util'
 import { JsonRpcProvider } from 'ethers'
 import BigNumber from 'bignumber.js'
@@ -24,7 +24,6 @@ export const AssetARB: TokenAsset = {
 }
 
 // Define JSON-RPC providers for mainnet and testnet
-// Ankr api key
 const ARBITRUM_MAINNET_ETHERS_PROVIDER = new JsonRpcProvider('https://arb1.arbitrum.io/rpc')
 const ARBITRUM_TESTNET_ETHERS_PROVIDER = new JsonRpcProvider('https://goerli-rollup.arbitrum.io/rpc')
 
@@ -35,32 +34,29 @@ const ethersJSProviders = {
   [Network.Stagenet]: ARBITRUM_MAINNET_ETHERS_PROVIDER,
 }
 
-// Define online providers (Etherscan) for mainnet and testnet
-const ARB_ONLINE_PROVIDER_MAINNET = new EtherscanProviderV2(
+// Etherscan providers removed - Etherscan's gas oracle doesn't support Arbitrum
+
+const ROUTESCAN_PROVIDER_MAINNET = new RoutescanProvider(
   ARBITRUM_MAINNET_ETHERS_PROVIDER,
-  'https://api.etherscan.io/v2',
-  process.env.ETHERSCAN_API_KEY || '',
-  ARBChain,
-  AssetAETH,
-  18,
+  'https://api.routescan.io',
   42161,
+  AssetAETH,
+  ARB_DECIMAL,
 )
 
-const ARB_ONLINE_PROVIDER_TESTNET = new EtherscanProviderV2(
+const ROUTESCAN_PROVIDER_TESTNET = new RoutescanProvider(
   ARBITRUM_TESTNET_ETHERS_PROVIDER,
-  'https://api.etherscan.io/v2',
-  process.env.ETHERSCAN_API_KEY || '',
-  ARBChain,
+  'https://api.routescan.io',
+  421613,
   AssetAETH,
-  18,
-  421614,
+  ARB_DECIMAL,
+  true,
 )
 
-// Define providers for different networks
-const arbProviders = {
-  [Network.Mainnet]: ARB_ONLINE_PROVIDER_MAINNET,
-  [Network.Testnet]: ARB_ONLINE_PROVIDER_TESTNET,
-  [Network.Stagenet]: ARB_ONLINE_PROVIDER_MAINNET,
+const routescanProviders = {
+  [Network.Mainnet]: ROUTESCAN_PROVIDER_MAINNET,
+  [Network.Testnet]: ROUTESCAN_PROVIDER_TESTNET,
+  [Network.Stagenet]: ROUTESCAN_PROVIDER_MAINNET,
 }
 
 // Define explorer providers for mainnet and testnet
@@ -120,7 +116,7 @@ export const defaultArbParams: EVMClientParams = {
   defaults,
   providers: ethersJSProviders,
   explorerProviders: arbExplorerProviders,
-  dataProviders: [arbProviders],
+  dataProviders: [routescanProviders],
   network: Network.Mainnet,
   feeBounds: {
     lower: LOWER_FEE_BOUND,

packages/xchain-evm-providers/src/providers/etherscan/etherscan-data-provider.ts

@@ -21,7 +21,7 @@ import { ERC20Tx, GetERC20TxsResponse } from './types'
 
 export class EtherscanProvider implements EvmOnlineDataProvider {
   private provider: Provider
-  private apiKey: string
+  protected apiKey: string
   protected baseUrl: string
   protected chain: Chain
   protected nativeAsset: Asset

packages/xchain-evm-providers/src/providers/routescan/routescan-data-provider.ts

@@ -1,5 +1,5 @@
 import { Provider } from 'ethers'
-import { TxHistoryParams } from '@xchainjs/xchain-client'
+import { FeeOption, FeeRates, TxHistoryParams } from '@xchainjs/xchain-client'
 import { Asset } from '@xchainjs/xchain-util'
 
 import { Tx, TxsPage } from '../../types'
@@ -79,4 +79,20 @@ export class RoutescanProvider extends EtherscanProvider {
       txs: transactions.filter((_, index) => index >= offset && index < offset + limit),
     }
   }
+
+  /**
+   * Override getFeeRates to handle Routescan's API response format correctly.
+   * Routescan returns gas prices in wei (not gwei), so we don't multiply by 10^9.
+   *
+   * @returns {Promise<FeeRates>} The fee rates in wei
+   */
+  async getFeeRates(): Promise<FeeRates> {
+    const gasOracleResponse = await etherscanAPI.getGasOracle(this.baseUrl, this.apiKey)
+
+    return {
+      [FeeOption.Average]: Number(gasOracleResponse.SafeGasPrice),
+      [FeeOption.Fast]: Number(gasOracleResponse.ProposeGasPrice),
+      [FeeOption.Fastest]: Number(gasOracleResponse.FastGasPrice),
+    }
+  }
 }