move the configuration hooks to a abstract base class

Author: keewis

pyproject.toml

@@ -51,7 +51,7 @@ ignore = [
     "E501", # E501: line too long - let black worry about that
     "E731", # E731: do not assign a lambda expression, use a def
 ]
-fixable = ["I"]
+fixable = ["I", "TID"]
 extend-safe-fixes = [
     "TID252",  # absolute imports
 ]

xarray_array_testing/base.py

@@ -0,0 +1,26 @@
+import abc
+from abc import ABC
+from types import ModuleType
+
+import numpy.testing as npt
+
+
+class DuckArrayTestMixin(ABC):
+    @property
+    @abc.abstractmethod
+    def xp() -> ModuleType:
+        pass
+
+    @property
+    @abc.abstractmethod
+    def array_type(self) -> type:
+        pass
+
+    @staticmethod
+    @abc.abstractmethod
+    def array_strategy_fn(*, shape, dtype):
+        raise NotImplementedError("has to be overridden")
+
+    @staticmethod
+    def assert_equal(a, b):
+        npt.assert_equal(a, b)

xarray_array_testing/creation.py

@@ -2,14 +2,10 @@
 import xarray.testing.strategies as xrst
 from hypothesis import given
 
+from xarray_array_testing.base import DuckArrayTestMixin
 
-class CreationTests:
-    array_type: type
-
-    @staticmethod
-    def array_strategy_fn(*, shape, dtype):
-        raise NotImplementedError
 
+class CreationTests(DuckArrayTestMixin):
     @given(st.data())
     def test_create_variable(self, data):
         variable = data.draw(xrst.variables(array_strategy_fn=self.array_strategy_fn))

xarray_array_testing/reduction.py

@@ -1,23 +1,13 @@
 from contextlib import nullcontext
-from types import ModuleType
 
 import hypothesis.strategies as st
-import numpy as np
 import xarray.testing.strategies as xrst
 from hypothesis import given
 
+from xarray_array_testing.base import DuckArrayTestMixin
 
-class ReductionTests:
-    xp: ModuleType
-
-    @staticmethod
-    def array_strategy_fn(*, shape, dtype):
-        raise NotImplementedError
-
-    @staticmethod
-    def assert_equal(a, b):
-        np.testing.assert_allclose(a, b)
 
+class ReductionTests(DuckArrayTestMixin):
     @staticmethod
     def expected_errors(op, **parameters):
         return nullcontext()

xarray_array_testing/tests/test_numpy.py

@@ -1,6 +1,7 @@
 import hypothesis.strategies as st
 import numpy as np
 
+from xarray_array_testing.base import DuckArrayTestMixin
 from xarray_array_testing.creation import CreationTests
 from xarray_array_testing.reduction import ReductionTests
 
@@ -9,17 +10,23 @@ def create_numpy_array(*, shape, dtype):
     return st.builds(np.ones, shape=st.just(shape), dtype=st.just(dtype))
 
 
-class TestCreationNumpy(CreationTests):
-    array_type = np.ndarray
+class NumpyTestMixin(DuckArrayTestMixin):
+    @property
+    def xp(self):
+        return np
+
+    @property
+    def array_type(self):
+        return np.ndarray
 
     @staticmethod
     def array_strategy_fn(*, shape, dtype):
         return create_numpy_array(shape=shape, dtype=dtype)
 
 
-class TestReductionNumpy(ReductionTests):
-    xp = np
+class TestCreationNumpy(CreationTests, NumpyTestMixin):
+    pass
 
-    @staticmethod
-    def array_strategy_fn(*, shape, dtype):
-        return create_numpy_array(shape=shape, dtype=dtype)
+
+class TestReductionNumpy(ReductionTests, NumpyTestMixin):
+    pass