You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 5, 2024. It is now read-only.
attendance-management-angular-13 (JS-0323) Detected usage of the any type
closes#13 by adding explicit type
feat(app): enhance authentication service and improve DTO imports
Update AuthService to include LoginToken alongside LoginDTO for improved type safety during login requests
Adjust return types within AuthService:
Replace generic Observable responses with specific HttpResponse variants involving either LoginToken/StatusMessageResponse or just StatusMessageResponse.
Modify AttendanceLineChartService's getAttendanceLineChart()/getSectionAttendanceLineChart() methods by specifying LineChartDTO in their return types while also importing it explicitly along with HttpResponse
Remove redundant HttpClient import statement from TopHeaderComponent
Enhance StudentService by returning more precise types:
Convert countStudentsBySection() method's return value to an observable emitting HttpResponse wrapping around a CountDTO object
Transform getAllStudents() method's result into an observable yielding StudentPaging objects rather than an unspecific any type
Refactor TeacherService to fetch Teacher entities wrapped inside HttpResponse instances via the getTeacherByUserId() function
Standardize SectionService by consistently utilizing observables encapsulating HTTP responses across all methods (createSection(), updateSection(), etc.) and importing required DTO classes like StatusMessageResponse upfront
Ensure proper typing throughout remaining components such as AnnouncementsComponent, AdminDashboardComponent, TeacherDashboardComponent, and TeacherStudentsComponent
0 commit comments