Skip to content

Commit 8bb1d0b

Browse files
authored
Remove gracefullyFinishThreads (#3057)
it's causing more harm than good due to constant interruptions
1 parent 50f0916 commit 8bb1d0b

File tree

3 files changed

+0
-25
lines changed

3 files changed

+0
-25
lines changed

vavr/src/test/java/io/vavr/concurrent/Concurrent.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
import io.vavr.CheckedFunction0;
2222
import io.vavr.control.Try;
2323
import java.util.Random;
24-
import java.util.concurrent.ForkJoinPool;
25-
import java.util.concurrent.TimeUnit;
26-
import java.util.concurrent.TimeoutException;
2724
import java.util.function.Supplier;
2825

2926
import static org.assertj.core.api.Assertions.fail;
@@ -75,13 +72,4 @@ static <T, X extends Throwable> CheckedFunction0<T> zZz(X exception) {
7572
throw exception;
7673
};
7774
}
78-
79-
static void gracefullyFinishThreads() throws TimeoutException {
80-
final boolean isQuiescent = ForkJoinPool.commonPool().awaitQuiescence(1L, TimeUnit.MINUTES);
81-
if (isQuiescent) {
82-
System.out.println("ForkJoinPool.commonPool() is quiecent");
83-
} else {
84-
throw new TimeoutException("Timeout while waiting for running threads in ForkJoinPool.commonPool() to finish.");
85-
}
86-
}
8775
}

vavr/src/test/java/io/vavr/concurrent/FutureTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
import java.util.concurrent.atomic.AtomicReference;
5151
import java.util.function.Function;
5252
import org.assertj.core.api.IterableAssert;
53-
import org.junit.jupiter.api.AfterAll;
5453
import org.junit.jupiter.api.Test;
5554
import org.junit.jupiter.api.extension.AfterEachCallback;
5655
import org.junit.jupiter.api.extension.BeforeEachCallback;
@@ -70,11 +69,6 @@ public class FutureTest extends AbstractValueTest {
7069

7170
private static final Executor REJECTING_EXECUTOR = ignored -> {throw new RejectedExecutionException();};
7271

73-
@AfterAll
74-
public static void gracefullyFinishThreads() throws TimeoutException {
75-
Concurrent.gracefullyFinishThreads();
76-
}
77-
7872
static class TraceUnitExtension implements AfterEachCallback, BeforeEachCallback {
7973

8074
@Override

vavr/src/test/java/io/vavr/concurrent/PromiseTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,13 @@
1919
package io.vavr.concurrent;
2020

2121
import io.vavr.control.Try;
22-
import java.util.concurrent.TimeoutException;
23-
import org.junit.jupiter.api.AfterAll;
2422
import org.junit.jupiter.api.Test;
2523

2624
import static org.assertj.core.api.Assertions.assertThat;
2725
import static org.junit.jupiter.api.Assertions.assertThrows;
2826

2927
public class PromiseTest {
3028

31-
@AfterAll
32-
public static void gracefullyFinishThreads() throws TimeoutException {
33-
Concurrent.gracefullyFinishThreads();
34-
}
35-
3629
@Test
3730
public void shouldReturnExecutorService() {
3831
final Promise<Integer> promise = Promise.successful(42);

0 commit comments

Comments
 (0)