warn about ... when not empty

Author: teunbrand

R/all-classes.R

@@ -218,6 +218,7 @@ class_theme <- S7::new_class(
     validate = S7::class_logical
   ),
   constructor = function(elements, complete, validate, ...) {
+    warn_dots_empty()
     S7::new_object(
       elements,
       complete = complete,
@@ -238,14 +239,15 @@ class_theme <- S7::new_class(
 #' @param ... Reserved for future expansion.
 #'
 #' @details
-#' All members of `labels` are expected to be named and unique.
+#' All members of `labels` are expected to be named and names should be unique.
 #'
 #'
 #' @keywords internal
 #' @export
 class_labels <- S7::new_class(
   "labels", parent = class_S3_gg,
   constructor = function(labels, ...) {
+    warn_dots_empty()
     S7::new_object(labels)
   },
   validator = function(self) {
@@ -281,6 +283,7 @@ class_labels <- S7::new_class(
 class_mapping <- S7::new_class(
   "mapping", parent = class_S3_gg,
   constructor = function(x, env = globalenv(), ...) {
+    warn_dots_empty()
     check_object(x, is.list, "a {.cls list}")
     x <- lapply(x, new_aesthetic, env = env)
     x <- S7::new_object(x)
@@ -346,6 +349,7 @@ class_ggplot <- S7::new_class(
     plot_env = parent.frame(),
     ...
   ) {
+    warn_dots_empty()
     S7::new_object(
       S7::S7_object(),
       data        = data,
@@ -389,6 +393,7 @@ class_ggplot_built <- S7::new_class(
     plot   = class_ggplot
   ),
   constructor = function(data = NULL, layout = NULL, plot = NULL, ...) {
+    warn_dots_empty()
     if (is.null(data) || is.null(layout) || is.null(plot)) {
       cli::cli_abort(
         "The {.cls ggplot_built} class should be constructed by {.fn ggplot_build}."

R/margins.R

@@ -8,6 +8,7 @@
 margin <- S7::new_class(
   "margin", parent = S7::new_S3_class(c("simpleUnit", "unit", "unit_v2")),
   constructor = function(t = 0, r = 0, b = 0, l = 0, unit = "pt", ...) {
+    warn_dots_empty()
     lens <- c(length(t), length(r), length(b), length(l))
     if (any(lens != 1)) {
       incorrect <- c("t", "r", "b", "l")[lens != 1]

R/theme-elements.R

@@ -140,6 +140,7 @@ element_rect <- S7::new_class(
   constructor = function(fill = NULL, colour = NULL, linewidth = NULL,
                          linetype = NULL, color = NULL, linejoin = NULL,
                          inherit.blank = FALSE, size = deprecated(), ...){
+    warn_dots_empty()
     if (lifecycle::is_present(size)) {
       deprecate_warn0("3.4.0", "element_rect(size)", "element_rect(linewidth)")
       linewidth <- size
@@ -174,6 +175,7 @@ element_line <- S7::new_class(
                          lineend = NULL, color = NULL, linejoin = NULL,
                          arrow = NULL, arrow.fill = NULL,
                          inherit.blank = FALSE, size = deprecated(), ...) {
+    warn_dots_empty()
     if (lifecycle::is_present(size)) {
       deprecate_warn0("3.4.0", "element_line(size)", "element_line(linewidth)")
       linewidth <- size
@@ -228,6 +230,7 @@ element_text <- S7::new_class(
                          size = NULL, hjust = NULL, vjust = NULL, angle = NULL,
                          lineheight = NULL, color = NULL, margin = NULL,
                          debug = NULL, inherit.blank = FALSE, ...) {
+    warn_dots_empty()
     n <- max(
       length(family), length(face), length(colour), length(size),
       length(hjust), length(vjust), length(angle), length(lineheight)
@@ -272,6 +275,7 @@ element_polygon <- S7::new_class(
   constructor = function(fill = NULL, colour = NULL, linewidth = NULL,
                          linetype = NULL, color = NULL, linejoin = NULL,
                          inherit.blank = FALSE, ...) {
+    warn_dots_empty()
     colour <- color %||% colour
     S7::new_object(
       S7::S7_object(),
@@ -293,6 +297,7 @@ element_point <- S7::new_class(
   ),
   constructor = function(colour = NULL, shape = NULL, size = NULL, fill = NULL,
                          stroke = NULL, color = NULL, inherit.blank = FALSE, ...) {
+    warn_dots_empty()
     S7::new_object(
       S7::S7_object(),
       colour = color %||% colour, fill = fill, shape = shape, size = size,
@@ -331,6 +336,7 @@ element_geom <- S7::new_class(
     pointsize = NULL, pointshape = NULL,
     colour = NULL, color = NULL, fill = NULL,
     ...) {
+    warn_dots_empty()
     if (!is.null(fontsize)) {
       fontsize <- fontsize / .pt
     }

R/utilities.R

@@ -850,6 +850,16 @@ warn_dots_used <- function(env = caller_env(), call = caller_env()) {
   )
 }
 
+warn_dots_empty <- function(env = caller_env(), call = caller_env()) {
+  check_dots_empty(
+    env = env, call = call,
+    error = function(cnd) {
+      msg <- gsub("\n", "\f", cnd_message(cnd))
+      cli::cli_warn(msg, call = call)
+    }
+  )
+}
+
 # TODO: Replace me if rlang/#1730 gets implemented
 # Similar to `rlang::check_installed()` but returns boolean and misses
 # features such as versions, comparisons and using {pak}.