Doesn't delete default-node-pool upon creation

[damdinsharav]

TL;DR

I've used this config for reference
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/examples/simple_regional_cluster_autoscaling/main.tf

I was expecting it delete default-node-pool after creation but the default node is still there.

It's working fine if add another node pool but I want setup without any node pool, only managed by NAP.

Expected behavior

It should delete the default node pool.

Observed behavior

No response

Terraform Configuration

module "gke" {
  source  = "terraform-google-modules/kubernetes-engine/google"
  version = "~> 37.0"

  project_id                = var.project_id
  name                      = "${local.cluster_type}-cluster${var.cluster_name_suffix}"
  regional                  = true
  region                    = var.region
  network                   = var.network
  subnetwork                = var.subnetwork
  ip_range_pods             = var.ip_range_pods
  ip_range_services         = var.ip_range_services
  create_service_account    = false
  service_account           = var.compute_engine_service_account
  default_max_pods_per_node = 20
  remove_default_node_pool  = true
  deletion_protection       = false

  add_cluster_firewall_rules = true
  firewall_inbound_ports     = ["8443", "9443", "15017"]

  # Just an example
  network_tags = ["egress-internet"]

  cluster_autoscaling = {
    enabled             = true
    autoscaling_profile = "OPTIMIZE_UTILIZATION"
    min_cpu_platform    = "Intel Skylake"
    min_cpu_cores       = 4
    max_cpu_cores       = 86
    min_memory_gb       = 16
    max_memory_gb       = 256
    disk_size           = 100
    disk_type           = "pd-standard"
    image_type          = "COS_CONTAINERD"
    gpu_resources       = []
    auto_repair         = true
    auto_upgrade        = true
    strategy            = "SURGE"
    max_surge           = 1
    max_unavailable     = 0
  }

Terraform Version

1.8.5

Terraform Provider Versions

google 6.11
kubernetes 2.10

Additional information

No response

[apeabody]

Hi @damdinsharav!

I believe the actual GKE default node pool is being deleted, however the node_pools variable defaults to creating a new node pool similarly named "default-node-pool" (which can be deleted). During a quick test the node_pools variable currently requires at least one node-pool be defined, using node_pools = [] will request in an error. So an enhancement is required to support no [] node pools.