Skip to content

Commit dc37e3b

Browse files
authored
Remove return type extension for wp_dropdown_users (#248)
As documented, `wp_dropdown_users()` always returns a string. See lines 1781-1784 in [wp-includes/user.php](https://github.com/WordPress/WordPress/blob/5cbec1348bf159844c572e4ff89043f4b95ca37a/wp-includes/user.php#L1781-L1784).
1 parent e9cfecf commit dc37e3b

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

src/EchoKeyDynamicFunctionReturnTypeExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class EchoKeyDynamicFunctionReturnTypeExtension implements \PHPStan\Type\Dynamic
3030
'get_search_form' => 0,
3131
'the_title_attribute' => 0,
3232
'wp_dropdown_languages' => 0,
33-
'wp_dropdown_users' => 0,
3433
'wp_get_archives' => 0,
3534
'wp_list_authors' => 0,
3635
'wp_list_bookmarks' => 0,
@@ -87,7 +86,6 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
8786
* @see https://developer.wordpress.org/reference/functions/get_search_form/
8887
* @see https://developer.wordpress.org/reference/functions/the_title_attribute/
8988
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_languages/
90-
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_users/
9189
* @see https://developer.wordpress.org/reference/functions/wp_get_archives/
9290
* @see https://developer.wordpress.org/reference/functions/wp_list_authors/
9391
* @see https://developer.wordpress.org/reference/functions/wp_list_bookmarks/

tests/data/echo_key.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
assertType('void', get_search_form());
1111
assertType('void', the_title_attribute());
1212
assertType('void', wp_dropdown_languages());
13-
assertType('void', wp_dropdown_users());
1413
assertType('void', wp_get_archives());
1514
assertType('void', wp_list_authors());
1615
assertType('void', wp_list_bookmarks());
@@ -26,7 +25,6 @@
2625
assertType('void', get_search_form($args));
2726
assertType('void', the_title_attribute($args));
2827
assertType('void', wp_dropdown_languages($args));
29-
assertType('void', wp_dropdown_users($args));
3028
assertType('void', wp_get_archives($args));
3129
assertType('void', wp_list_authors($args));
3230
assertType('void', wp_list_bookmarks($args));
@@ -40,7 +38,6 @@
4038
// Explicit array key value of 1
4139
$args = ['echo' => 1];
4240
assertType('void', wp_dropdown_languages($args));
43-
assertType('void', wp_dropdown_users($args));
4441
assertType('void', wp_get_archives($args));
4542
assertType('void', wp_list_bookmarks($args));
4643
assertType('void|false', wp_list_categories($args));
@@ -50,7 +47,6 @@
5047
assertType('string', get_search_form($args));
5148
assertType('string|void', the_title_attribute($args));
5249
assertType('string|void', wp_dropdown_languages($args));
53-
assertType('string', wp_dropdown_users($args));
5450
assertType('string|void', wp_get_archives($args));
5551
assertType('string', wp_list_authors($args));
5652
assertType('string', wp_list_bookmarks($args));
@@ -64,7 +60,6 @@
6460
// Explicit array key value of 0
6561
$args = ['echo' => 0];
6662
assertType('string|void', wp_dropdown_languages($args));
67-
assertType('string', wp_dropdown_users($args));
6863
assertType('string|void', wp_get_archives($args));
6964
assertType('string', wp_list_bookmarks($args));
7065
assertType('string|false', wp_list_categories($args));
@@ -74,7 +69,6 @@
7469
assertType('string|void', get_search_form($args));
7570
assertType('string|void', the_title_attribute($args));
7671
assertType('string|void', wp_dropdown_languages($args));
77-
assertType('string|void', wp_dropdown_users($args));
7872
assertType('string|void', wp_get_archives($args));
7973
assertType('string|void', wp_list_authors($args));
8074
assertType('string|void', wp_list_bookmarks($args));
@@ -89,7 +83,6 @@
8983
$args = 'akey=avalue';
9084
assertType('void', the_title_attribute($args));
9185
assertType('void', wp_dropdown_languages($args));
92-
assertType('void', wp_dropdown_users($args));
9386
assertType('void', wp_get_archives($args));
9487
assertType('void', wp_list_authors($args));
9588
assertType('void', wp_list_bookmarks($args));
@@ -103,7 +96,6 @@
10396
$args = 'echo=nonemptynonnumeric&akey=avalue';
10497
assertType('void', the_title_attribute($args));
10598
assertType('void', wp_dropdown_languages($args));
106-
assertType('void', wp_dropdown_users($args));
10799
assertType('void', wp_get_archives($args));
108100
assertType('void', wp_list_authors($args));
109101
assertType('void', wp_list_bookmarks($args));
@@ -117,7 +109,6 @@
117109
$args = 'echo=1&akey=avalue';
118110
assertType('void', the_title_attribute($args));
119111
assertType('void', wp_dropdown_languages($args));
120-
assertType('void', wp_dropdown_users($args));
121112
assertType('void', wp_get_archives($args));
122113
assertType('void', wp_list_authors($args));
123114
assertType('void', wp_list_bookmarks($args));
@@ -131,7 +122,6 @@
131122
$args = 'echo=0&akey=avalue';
132123
assertType('string|void', the_title_attribute($args));
133124
assertType('string|void', wp_dropdown_languages($args));
134-
assertType('string', wp_dropdown_users($args));
135125
assertType('string|void', wp_get_archives($args));
136126
assertType('string', wp_list_authors($args));
137127
assertType('string', wp_list_bookmarks($args));
@@ -145,7 +135,6 @@
145135
$args = 'echo=&akey=avalue';
146136
assertType('string|void', the_title_attribute($args));
147137
assertType('string|void', wp_dropdown_languages($args));
148-
assertType('string', wp_dropdown_users($args));
149138
assertType('string|void', wp_get_archives($args));
150139
assertType('string', wp_list_authors($args));
151140
assertType('string', wp_list_bookmarks($args));
@@ -160,7 +149,6 @@
160149
assertType('string|void', get_search_form($args));
161150
assertType('string|void', the_title_attribute($args));
162151
assertType('string|void', wp_dropdown_languages($args));
163-
assertType('string|void', wp_dropdown_users($args));
164152
assertType('string|void', wp_get_archives($args));
165153
assertType('string|void', wp_list_authors($args));
166154
assertType('string|void', wp_list_bookmarks($args));
@@ -177,7 +165,6 @@
177165
assertType('string|void', get_search_form($args));
178166
assertType('string|void', the_title_attribute($args));
179167
assertType('string|void', wp_dropdown_languages($args));
180-
assertType('string|void', wp_dropdown_users($args));
181168
assertType('string|void', wp_get_archives($args));
182169
assertType('string|void', wp_list_authors($args));
183170
assertType('string|void', wp_list_bookmarks($args));

0 commit comments

Comments
 (0)