Merge pull request #61 from johnbillion/tests-get-post

Author: szepeviktor

src/GetPostDynamicFunctionReturnTypeExtension.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Type;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\StringType;
@@ -20,6 +21,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\Constant\ConstantStringType;
 
 class GetPostDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
 {
@@ -32,6 +34,20 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
     public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
     {
         $output = 'OBJECT';
+
+        if (count($functionCall->args) >= 2) {
+            $argumentType = $scope->getType($functionCall->args[1]->value);
+
+            // When called with an $output that isn't a constant string, return default return type
+            if (! $argumentType instanceof ConstantStringType) {
+                return ParametersAcceptorSelector::selectFromArgs(
+                    $scope,
+                    $functionCall->args,
+                    $functionReflection->getVariants()
+                )->getReturnType();
+            }
+        }
+
         if (count($functionCall->args) >= 2 && $functionCall->args[1]->value instanceof ConstFetch) {
             $output = $functionCall->args[1]->value->name->getLast();
         }

tests/data/get_post.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SzepeViktor\PHPStan\WordPress\Tests;
+
+use function PHPStan\Testing\assertType;
+
+// Default output
+assertType('WP_Post|null', get_post(1));
+assertType('WP_Post|null', get_post(1,OBJECT));
+assertType('WP_Post|null', get_post(1,'Hello'));
+
+// Unknown output
+assertType('array|\WP_Post|null', get_post(1,_GET['foo']));
+
+// Associative array output
+assertType('array<string, mixed>|null', get_post(1,ARRAY_A));
+
+// Numeric array output
+assertType('array<int, mixed>|null', get_post(1,ARRAY_N));

tests/testTest.php

@@ -18,6 +18,7 @@ public function dataFileAsserts(): iterable
         yield from $this->gatherAssertTypes(__DIR__ . '/data/current_time.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_comment.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_object_taxonomies.php');
+        yield from $this->gatherAssertTypes(__DIR__ . '/data/get_post.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/mysql2date.php');
     }