remove else statement

IanDelMar · IanDelMar · commit 2a284d842e37 · 2024-06-28T20:55:03.000+02:00
diff --git a/src/WpParseUrlFunctionDynamicReturnTypeExtension.php b/src/WpParseUrlFunctionDynamicReturnTypeExtension.php
@@ -66,6 +66,8 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
         $this->cacheReturnTypes();
 
+        $componentType = new ConstantIntegerType(-1);
+
         if (count($functionCall->getArgs()) > 1) {
             $componentType = $scope->getType($functionCall->getArgs()[1]->value);
 
@@ -78,8 +80,6 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
             if (! $componentType instanceof ConstantIntegerType) {
                 return $this->createAllComponentsReturnType();
             }
-        } else {
-            $componentType = new ConstantIntegerType(-1);
         }
 
         $urlType = $scope->getType($functionCall->getArgs()[0]->value);

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,8 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,`
`66`	`66`
`67`	`67`	`$this->cacheReturnTypes();`
`68`	`68`
	`69`	`+ $componentType = new ConstantIntegerType(-1);`
	`70`	`+`
`69`	`71`	`if (count($functionCall->getArgs()) > 1) {`
`70`	`72`	`$componentType = $scope->getType($functionCall->getArgs()[1]->value);`
`71`	`73`
`@@ -78,8 +80,6 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,`
`78`	`80`	`if (! $componentType instanceof ConstantIntegerType) {`
`79`	`81`	`return $this->createAllComponentsReturnType();`
`80`	`82`	`}`
`81`		`- } else {`
`82`		`- $componentType = new ConstantIntegerType(-1);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`$urlType = $scope->getType($functionCall->getArgs()[0]->value);`