Merge branch 'master' into _get_list_table

# Conflicts:
#	tests/testTest.php

Author: johnbillion

.travis.yml

@@ -1,5 +1,7 @@
 # TravisCI configuration for szepeviktor/phpstan-wordpress
 
+if: "branch = master"
+
 language: "php"
 os:
   - "linux"
@@ -23,6 +25,6 @@ install:
 
 script:
   - "composer test:syntax -- --no-progress"
-  - "composer test:phpunit"
+  - "composer test:phpunit -- --verbose"
   - "composer test:cs -- -s"
   - "composer test:phpstan -- --ansi --memory-limit=1G --no-progress"

extension.neon

@@ -47,6 +47,10 @@ services:
         class: SzepeViktor\PHPStan\WordPress\MySQL2DateDynamicFunctionReturnTypeExtension
         tags:
             - phpstan.broker.dynamicFunctionReturnTypeExtension
+    -
+        class: SzepeViktor\PHPStan\WordPress\CurrentTimeDynamicFunctionReturnTypeExtension
+        tags:
+            - phpstan.broker.dynamicFunctionReturnTypeExtension
 parameters:
     bootstrapFiles:
         - %rootDir%/../../php-stubs/wordpress-stubs/wordpress-stubs.php

src/CurrentTimeDynamicFunctionReturnTypeExtension.php

@@ -0,0 +1,53 @@
+<?php
+
+/**
+ * Set return type of current_time().
+ */
+
+declare(strict_types=1);
+
+namespace SzepeViktor\PHPStan\WordPress;
+
+use PhpParser\Node\Expr\FuncCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Type\Type;
+use PHPStan\Type\IntegerType;
+use PHPStan\Type\StringType;
+use PHPStan\Type\Constant\ConstantStringType;
+
+class CurrentTimeDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
+{
+    public function isFunctionSupported(FunctionReflection $functionReflection): bool
+    {
+        return in_array($functionReflection->getName(), ['current_time'], true);
+    }
+
+    /**
+     * @see https://developer.wordpress.org/reference/functions/current_time/
+     */
+    public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
+    {
+        $argumentType = $scope->getType($functionCall->args[0]->value);
+
+        // When called with a $type that isn't a constant string, return default return type
+        if (! $argumentType instanceof ConstantStringType) {
+            return ParametersAcceptorSelector::selectFromArgs(
+                $scope,
+                $functionCall->args,
+                $functionReflection->getVariants()
+            )->getReturnType();
+        }
+
+        // Called with a constant string $type
+        switch ($argumentType->getValue()) {
+            case 'timestamp':
+            case 'U':
+                return new IntegerType();
+            case 'mysql':
+            default:
+                return new StringType();
+        }
+    }
+}

src/GetPostDynamicFunctionReturnTypeExtension.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Type;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\StringType;
@@ -20,6 +21,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\Constant\ConstantStringType;
 
 class GetPostDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
 {
@@ -32,6 +34,20 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
     public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
     {
         $output = 'OBJECT';
+
+        if (count($functionCall->args) >= 2) {
+            $argumentType = $scope->getType($functionCall->args[1]->value);
+
+            // When called with an $output that isn't a constant string, return default return type
+            if (! $argumentType instanceof ConstantStringType) {
+                return ParametersAcceptorSelector::selectFromArgs(
+                    $scope,
+                    $functionCall->args,
+                    $functionReflection->getVariants()
+                )->getReturnType();
+            }
+        }
+
         if (count($functionCall->args) >= 2 && $functionCall->args[1]->value instanceof ConstFetch) {
             $output = $functionCall->args[1]->value->name->getLast();
         }

tests/data/current_time.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SzepeViktor\PHPStan\WordPress\Tests;
+
+use function current_time;
+use function PHPStan\Testing\assertType;
+use stdClass;
+
+// Integer types
+assertType('int', current_time('timestamp'));
+assertType('int', current_time('U'));
+
+// String types
+assertType('string', current_time('mysql'));
+assertType('string', current_time('Hello'));
+
+// Unknown types
+assertType('int|string', current_time($_GET['foo']));
+assertType('int|string', current_time(get_option('date_format')));
+
+// Unsupported types
+assertType('int|string', current_time(new stdClass));
+assertType('int|string', current_time(false));

tests/data/get_post.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SzepeViktor\PHPStan\WordPress\Tests;
+
+use function PHPStan\Testing\assertType;
+
+// Default output
+assertType('WP_Post|null', get_post(1));
+assertType('WP_Post|null', get_post(1,OBJECT));
+assertType('WP_Post|null', get_post(1,'Hello'));
+
+// Unknown output
+assertType('array|\WP_Post|null', get_post(1,_GET['foo']));
+
+// Associative array output
+assertType('array<string, mixed>|null', get_post(1,ARRAY_A));
+
+// Numeric array output
+assertType('array<int, mixed>|null', get_post(1,ARRAY_N));

tests/testTest.php

@@ -16,8 +16,10 @@ public function dataFileAsserts(): iterable
     {
         // path to a file with actual asserts of expected types:
         yield from $this->gatherAssertTypes(__DIR__ . '/data/_get_list_table.php');
+        yield from $this->gatherAssertTypes(__DIR__ . '/data/current_time.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_comment.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_object_taxonomies.php');
+        yield from $this->gatherAssertTypes(__DIR__ . '/data/get_post.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/mysql2date.php');
     }