Allow array like types in StringOrArrayDynamicFunctionReturnTypeExtension (#96)

Author: Hug0-Drelon

src/StringOrArrayDynamicFunctionReturnTypeExtension.php

@@ -14,6 +14,7 @@
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\StringType;
 use PHPStan\Type\ArrayType;
+use PHPStan\Type\IntegerType;
 use PHPStan\Type\Type;
 
 class StringOrArrayDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
@@ -34,13 +35,14 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
                 $functionReflection->getVariants()
             )->getReturnType();
         }
-
         $dataArg = $args[0]->value;
         $dataArgType = $scope->getType($dataArg);
-        if ($dataArgType instanceof ArrayType) {
+        if ($dataArgType->isArray()->yes()) {
             $keyType = $dataArgType->getIterableKeyType();
-            $itemType = $dataArgType->getIterableValueType();
-            return new ArrayType($keyType, $itemType);
+            if ($keyType instanceof StringType) {
+                return new ArrayType(new StringType(), new StringType());
+            }
+            return new ArrayType(new IntegerType(), new StringType());
         }
         return new StringType();
     }

tests/DynamicReturnTypeExtensionTest.php

@@ -16,6 +16,7 @@ public function dataFileAsserts(): iterable
         yield from $this->gatherAssertTypes(__DIR__ . '/data/apply_filters.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/current_time.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/echo_parameter.php');
+        yield from $this->gatherAssertTypes(__DIR__ . '/data/esc_sql.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_comment.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_object_taxonomies.php');
         yield from $this->gatherAssertTypes(__DIR__ . '/data/get_post.php');

tests/data/esc_sql.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SzepeViktor\PHPStan\WordPress\Tests;
+
+use stdClass;
+
+use function PHPStan\Testing\assertType;
+
+// Indexed array as parameter
+assertType('array<int, string>', esc_sql(['someValue', 'toEscape']));
+
+// Associative array as parameter
+assertType('array<string, string>', esc_sql(['someValue' => 'toEscape']));
+
+// String as parameter
+assertType('string', esc_sql('someValueToEscape'));
+
+// Wrong type provided (esc_sql() returns an empty string in that case)
+assertType('string', esc_sql(new \stdClass()));